You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/12/08 16:59:20 UTC
[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10653: Fix post-aggregator computation when used with subtotals
abhishekagarwal87 commented on a change in pull request #10653:
URL: https://github.com/apache/druid/pull/10653#discussion_r538602500
##########
File path: processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java
##########
@@ -442,8 +425,8 @@ public boolean doMergeResults(final GroupByQuery query)
}
GroupByQuery subtotalQuery = baseSubtotalQuery
- .withLimitSpec(subtotalQueryLimitSpec)
- .withDimensionSpecs(newDimensions);
+ .withLimitSpec(subtotalQueryLimitSpec);
+ //.withDimensionSpecs(newDimensions);
Review comment:
Yup. I had removed it on my local but forgot to push.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org