You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/02/12 15:57:47 UTC
[GitHub] flink pull request #5466: [FLINK-8530] [flip6] Enable detached job mode subm...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5466
[FLINK-8530] [flip6] Enable detached job mode submission to session cluster
## What is the purpose of the change
This commit makes the RestClusterClient aware whether the user wishes to submit
a job in detached or non-detached mode. If it is detached, then the RestClusterClient
won't poll for the execution result.
This PR is based on #5428.
## Verifying this change
- Added `RestClusterClientTest#testDetachedJobSubmission`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink enableDetachedMode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5466
----
commit b2647f8d4f5e264640396d7fe72d8a392c89359b
Author: Till Rohrmann <tr...@...>
Date: 2018-02-06T15:46:52Z
[FLINK-8603] [flip6] Split submitJob into job submission and execution result retrieval
Split RestClusterClient#submitJob into submitJob and requestJobResult which can
be called individually.
commit cfb0371ef8675ee65f3ed8af39bc5d29807d7c45
Author: Till Rohrmann <tr...@...>
Date: 2018-02-12T15:33:15Z
[FLINK-8530] [flip6] Enable detached job mode submission to session cluster
This commit makes the RestClusterClient aware whether the user wishes to submit
a job in detached or non-detached mode. If it is detached, then the RestClusterClient
won't poll for the execution result.
----
---
[GitHub] flink pull request #5466: [FLINK-8530] [flip6] Enable detached job mode subm...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5466#discussion_r168233601
--- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java ---
@@ -509,7 +536,7 @@ public void testListJobs() throws Exception {
Iterator<JobStatusMessage> jobDetailsIterator = jobDetails.iterator();
JobStatusMessage job1 = jobDetailsIterator.next();
JobStatusMessage job2 = jobDetailsIterator.next();
- Assert.assertNotEquals("The job statues should not be equal.", job1.getJobState(), job2.getJobState());
+ Assert.assertNotEquals("The jobGraph statues should not be equal.", job1.getJobState(), job2.getJobState());
--- End diff --
Will fix it.
---
[GitHub] flink pull request #5466: [FLINK-8530] [flip6] Enable detached job mode subm...
Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5466#discussion_r168200092
--- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java ---
@@ -509,7 +536,7 @@ public void testListJobs() throws Exception {
Iterator<JobStatusMessage> jobDetailsIterator = jobDetails.iterator();
JobStatusMessage job1 = jobDetailsIterator.next();
JobStatusMessage job2 = jobDetailsIterator.next();
- Assert.assertNotEquals("The job statues should not be equal.", job1.getJobState(), job2.getJobState());
+ Assert.assertNotEquals("The jobGraph statues should not be equal.", job1.getJobState(), job2.getJobState());
--- End diff --
previous message was fine ... also *status*
---
[GitHub] flink pull request #5466: [FLINK-8530] [flip6] Enable detached job mode subm...
Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5466#discussion_r168199770
--- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java ---
@@ -493,7 +520,7 @@ public void testTriggerSavepoint() throws Exception {
} else {
return FutureUtils.completedExceptionally(
new RestHandlerException(
- "Unexpected savepoint trigger id: " + savepointTriggerId,
+ "Unexpected savepoint trigger jobId: " + savepointTriggerId,
--- End diff --
something went wrong here
---
[GitHub] flink issue #5466: [FLINK-8530] [flip6] Enable detached job mode submission ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5466
Thanks for the review @GJL. I've addressed your feedback and rebased onto the latest soon to be master.
---
[GitHub] flink pull request #5466: [FLINK-8530] [flip6] Enable detached job mode subm...
Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5466#discussion_r168199581
--- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java ---
@@ -456,7 +483,7 @@ public void testTriggerSavepoint() throws Exception {
return CompletableFuture.completedFuture(
new SavepointTriggerResponseBody(testSavepointTriggerId));
} else {
- // return new random savepoint trigger id so that test can fail
+ // return new random savepoint trigger jobId so that test can fail
--- End diff --
no
---
[GitHub] flink pull request #5466: [FLINK-8530] [flip6] Enable detached job mode subm...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5466#discussion_r168233566
--- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java ---
@@ -493,7 +520,7 @@ public void testTriggerSavepoint() throws Exception {
} else {
return FutureUtils.completedExceptionally(
new RestHandlerException(
- "Unexpected savepoint trigger id: " + savepointTriggerId,
+ "Unexpected savepoint trigger jobId: " + savepointTriggerId,
--- End diff --
Will fix it.
---
[GitHub] flink pull request #5466: [FLINK-8530] [flip6] Enable detached job mode subm...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5466#discussion_r168233528
--- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java ---
@@ -456,7 +483,7 @@ public void testTriggerSavepoint() throws Exception {
return CompletableFuture.completedFuture(
new SavepointTriggerResponseBody(testSavepointTriggerId));
} else {
- // return new random savepoint trigger id so that test can fail
+ // return new random savepoint trigger jobId so that test can fail
--- End diff --
True, will fix it.
---
[GitHub] flink pull request #5466: [FLINK-8530] [flip6] Enable detached job mode subm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5466
---