You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/06/09 21:48:15 UTC
Review Request: SQOOP-1059 Sqoop2: Remove ad hoc modle cloning methods in
common module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11768/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've removed the adhoc code and reused the model's clone method instead.
This addresses bug SQOOP-1059.
https://issues.apache.org/jira/browse/SQOOP-1059
Diffs
-----
core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759ea0825438de26b3538acca95a72a2a359
Diff: https://reviews.apache.org/r/11768/diff/
Testing
-------
Unit and integration tests seems to be passing.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-1059 Sqoop2: Remove ad hoc modle cloning methods
in common module
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11768/#review22312
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On June 24, 2013, 3:51 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11768/
> -----------------------------------------------------------
>
> (Updated June 24, 2013, 3:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've removed the adhoc code and reused the model's clone method instead.
>
>
> This addresses bug SQOOP-1059.
> https://issues.apache.org/jira/browse/SQOOP-1059
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/repository/Repository.java a2911c5c0c050fe39fb03e3a66b609e363ca8f71
>
> Diff: https://reviews.apache.org/r/11768/diff/
>
>
> Testing
> -------
>
> Unit and integration tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-1059 Sqoop2: Remove ad hoc modle cloning methods
in common module
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11768/
-----------------------------------------------------------
(Updated June 24, 2013, 3:51 a.m.)
Review request for Sqoop.
Changes
-------
Rebased on current HEAD of the sqoop2 branch.
Description
-------
I've removed the adhoc code and reused the model's clone method instead.
This addresses bug SQOOP-1059.
https://issues.apache.org/jira/browse/SQOOP-1059
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/repository/Repository.java a2911c5c0c050fe39fb03e3a66b609e363ca8f71
Diff: https://reviews.apache.org/r/11768/diff/
Testing
-------
Unit and integration tests seems to be passing.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-1059 Sqoop2: Remove ad hoc modle cloning methods
in common module
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11768/#review21641
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On June 9, 2013, 7:48 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11768/
> -----------------------------------------------------------
>
> (Updated June 9, 2013, 7:48 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've removed the adhoc code and reused the model's clone method instead.
>
>
> This addresses bug SQOOP-1059.
> https://issues.apache.org/jira/browse/SQOOP-1059
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759ea0825438de26b3538acca95a72a2a359
>
> Diff: https://reviews.apache.org/r/11768/diff/
>
>
> Testing
> -------
>
> Unit and integration tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-1059 Sqoop2: Remove ad hoc modle cloning methods
in common module
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11768/#review21639
-----------------------------------------------------------
Ship it!
LGTM - Thanks
- Venkat Ranganathan
On June 9, 2013, 7:48 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11768/
> -----------------------------------------------------------
>
> (Updated June 9, 2013, 7:48 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've removed the adhoc code and reused the model's clone method instead.
>
>
> This addresses bug SQOOP-1059.
> https://issues.apache.org/jira/browse/SQOOP-1059
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759ea0825438de26b3538acca95a72a2a359
>
> Diff: https://reviews.apache.org/r/11768/diff/
>
>
> Testing
> -------
>
> Unit and integration tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>