[GitHub] [solr] dsmiley commented on pull request #1374: SOLR-16623:SolrClientTestRule for JettySolrRunnerV2

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on PR #1374:
URL: https://github.com/apache/solr/pull/1374#issuecomment-1458876462

   I don't recommend adding `// nocommit: Fails` type comments.  The CI results tells you what fails, which can change as you improve things.  In fact you just made a critical improvement and it seems there are only a few failures left.  How's it going with them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org