You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2018/03/02 14:51:37 UTC
[GitHub] nifi pull request #2504: NIFI-4773: Fixed column type map initialization in ...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2504
NIFI-4773: Fixed column type map initialization in QueryDatabaseTable
I added unit tests to both QDT and GTF, the former to show the issue is fixed (the test fails without the fix), and the latter to show that the fix does not introduce a regresstion to GTF (since there was a change to the shared base class).
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4773
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2504.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2504
----
commit e11e2f841b005836a16b54bfff9d2f112d978efe
Author: Matthew Burgess <ma...@...>
Date: 2018-03-02T14:49:25Z
NIFI-4773: Fixed column type map initialization in QueryDatabaseTable
----
---
[GitHub] nifi pull request #2504: NIFI-4773: Fixed column type map initialization in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2504
---
[GitHub] nifi pull request #2504: NIFI-4773: Fixed column type map initialization in ...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2504#discussion_r171882320
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java ---
@@ -197,6 +198,12 @@ public void setup(final ProcessContext context) {
maxValueProperties = getDefaultMaxValueProperties(context.getProperties());
}
+ @OnStopped
+ public void stop() {
+ // Reset the column type map in case properties change
+ setupComplete.set(false);
--- End diff --
can't we just do the setup in `@OnScheduled` and move the setupComplete flag only to `GenerateTableFetch` or remove it? I think the code would be more straightforward like this. What do you think?
---
[GitHub] nifi pull request #2504: NIFI-4773: Fixed column type map initialization in ...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2504#discussion_r171887381
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java ---
@@ -197,6 +198,12 @@ public void setup(final ProcessContext context) {
maxValueProperties = getDefaultMaxValueProperties(context.getProperties());
}
+ @OnStopped
+ public void stop() {
+ // Reset the column type map in case properties change
+ setupComplete.set(false);
--- End diff --
I see, thanks for your explaination
---
[GitHub] nifi pull request #2504: NIFI-4773: Fixed column type map initialization in ...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2504#discussion_r171886997
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java ---
@@ -197,6 +198,12 @@ public void setup(final ProcessContext context) {
maxValueProperties = getDefaultMaxValueProperties(context.getProperties());
}
+ @OnStopped
+ public void stop() {
+ // Reset the column type map in case properties change
+ setupComplete.set(false);
--- End diff --
That's what it used to do, NIFI-4773 was to do the opposite. It's not recommended to try to connect to external systems in `@OnScheduled` due to timeouts and other possible errors. Instead we moved it into onTrigger but only to be done once.
---
[GitHub] nifi issue #2504: NIFI-4773: Fixed column type map initialization in QueryDa...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2504
+1, merging to master, thanks @mattyb149 !
---