You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/15 13:44:54 UTC
[GitHub] [beam] egalpin opened a new pull request, #21884: Revert "[BEAM-14064] fix es io windowing (#17112)"
egalpin opened a new pull request, #21884:
URL: https://github.com/apache/beam/pull/21884
This reverts commit 77833b19371a213ef11439b2925fa421af79b641.
As per #21690, this PR is a temporary fix to the window casting error (regression) introduced by #17112. By reverting, a potential data-correctness bug is being explicitly added back wherein responses from Elasticsearch could be output to a window which does not correspond to the input.
My assessment is that the data-correctness bug likely has a very low impact to pipeline authors. It still needs to be addressed, but the potential data-correctness bug is the much lesser evil compared to the state of ElasticsearchIO in 2.39.0
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] egalpin commented on pull request #21884: Revert "[BEAM-14064] fix es io windowing (#17112)"
Posted by GitBox <gi...@apache.org>.
egalpin commented on PR #21884:
URL: https://github.com/apache/beam/pull/21884#issuecomment-1156494434
R: @aaltay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] egalpin closed pull request #21884: Revert "[BEAM-14064] fix es io windowing (#17112)"
Posted by GitBox <gi...@apache.org>.
egalpin closed pull request #21884: Revert "[BEAM-14064] fix es io windowing (#17112)"
URL: https://github.com/apache/beam/pull/21884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #21884: Revert "[BEAM-14064] fix es io windowing (#17112)"
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #21884:
URL: https://github.com/apache/beam/pull/21884#issuecomment-1157102959
LGTM - Clean revert.
As discussed on the other thread, feel free to either pick this or the forward fix as the solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] egalpin commented on pull request #21884: Revert "[BEAM-14064] fix es io windowing (#17112)"
Posted by GitBox <gi...@apache.org>.
egalpin commented on PR #21884:
URL: https://github.com/apache/beam/pull/21884#issuecomment-1157801471
Closing as the fix https://github.com/apache/beam/pull/21895 was preferred over revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #21884: Revert "[BEAM-14064] fix es io windowing (#17112)"
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21884:
URL: https://github.com/apache/beam/pull/21884#issuecomment-1157013058
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org