You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2016/12/07 01:35:38 UTC

Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54460/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-19117
    https://issues.apache.org/jira/browse/AMBARI-19117


Repository: ambari


Description
-------

This is a FE task to implement the "Create Alerts Wizard " based on the design attached.

This task is to create Step 2 of PORT alert. see the design for details. 
Pay attention to the dependencies on selecting different options. The further fields will determined by the current selection.

eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display totally different UI.


Diffs
-----

  ambari-web/app/config.js 130cb39 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 7fb4b2d 
  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 138aaa4 
  ambari-web/app/models/alerts/alert_config.js 980dfe5 
  ambari-web/app/styles/alerts.less 77cc13c 
  ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 

Diff: https://reviews.apache.org/r/54460/diff/


Testing
-------


Thanks,

Xi Wang


Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54460/#review159645
-----------------------------------------------------------


Ship it!




Ship It!

- Jaimin Jetly


On Dec. 19, 2016, 7:38 p.m., Xi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54460/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2016, 7:38 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19117
>     https://issues.apache.org/jira/browse/AMBARI-19117
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is a FE task to implement the "Create Alerts Wizard " based on the design attached.
> 
> This task is to create Step 2 of PORT alert. see the design for details. 
> Pay attention to the dependencies on selecting different options. The further fields will determined by the current selection.
> 
> eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display totally different UI.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/config.js 130cb39 
>   ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 7fb4b2d 
>   ambari-web/app/controllers/main/alerts/definition_configs_controller.js 138aaa4 
>   ambari-web/app/models/alerts/alert_config.js 980dfe5 
>   ambari-web/app/styles/alerts.less 77cc13c 
>   ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 
> 
> Diff: https://reviews.apache.org/r/54460/diff/
> 
> 
> Testing
> -------
> 
> 19713 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>


Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54460/
-----------------------------------------------------------

(Updated Dec. 19, 2016, 11:38 a.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-19117
    https://issues.apache.org/jira/browse/AMBARI-19117


Repository: ambari


Description
-------

This is a FE task to implement the "Create Alerts Wizard " based on the design attached.

This task is to create Step 2 of PORT alert. see the design for details. 
Pay attention to the dependencies on selecting different options. The further fields will determined by the current selection.

eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display totally different UI.


Diffs
-----

  ambari-web/app/config.js 130cb39 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 7fb4b2d 
  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 138aaa4 
  ambari-web/app/models/alerts/alert_config.js 980dfe5 
  ambari-web/app/styles/alerts.less 77cc13c 
  ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 

Diff: https://reviews.apache.org/r/54460/diff/


Testing (updated)
-------

19713 passing (21s)
  153 pending


Thanks,

Xi Wang


Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54460/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 4:53 p.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-19117
    https://issues.apache.org/jira/browse/AMBARI-19117


Repository: ambari


Description
-------

This is a FE task to implement the "Create Alerts Wizard " based on the design attached.

This task is to create Step 2 of PORT alert. see the design for details. 
Pay attention to the dependencies on selecting different options. The further fields will determined by the current selection.

eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display totally different UI.


Diffs (updated)
-----

  ambari-web/app/config.js 130cb39 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 7fb4b2d 
  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 138aaa4 
  ambari-web/app/models/alerts/alert_config.js 980dfe5 
  ambari-web/app/styles/alerts.less 77cc13c 
  ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 

Diff: https://reviews.apache.org/r/54460/diff/


Testing
-------


Thanks,

Xi Wang


Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54460/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 4:53 p.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-19117
    https://issues.apache.org/jira/browse/AMBARI-19117


Repository: ambari


Description
-------

This is a FE task to implement the "Create Alerts Wizard " based on the design attached.

This task is to create Step 2 of PORT alert. see the design for details. 
Pay attention to the dependencies on selecting different options. The further fields will determined by the current selection.

eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display totally different UI.


Diffs
-----

  ambari-web/app/config.js 130cb39 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 7fb4b2d 
  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 138aaa4 
  ambari-web/app/models/alerts/alert_config.js 980dfe5 
  ambari-web/app/styles/alerts.less 77cc13c 
  ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 

Diff: https://reviews.apache.org/r/54460/diff/


Testing
-------


Thanks,

Xi Wang


Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54460/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 4:52 p.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-19117
    https://issues.apache.org/jira/browse/AMBARI-19117


Repository: ambari


Description
-------

This is a FE task to implement the "Create Alerts Wizard " based on the design attached.

This task is to create Step 2 of PORT alert. see the design for details. 
Pay attention to the dependencies on selecting different options. The further fields will determined by the current selection.

eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display totally different UI.


Diffs
-----

  ambari-web/app/config.js 130cb39 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 7fb4b2d 
  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 138aaa4 
  ambari-web/app/models/alerts/alert_config.js 980dfe5 
  ambari-web/app/styles/alerts.less 77cc13c 
  ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 

Diff: https://reviews.apache.org/r/54460/diff/


Testing
-------


File Attachments (updated)
----------------

AMBARI-19117.patch
  https://reviews.apache.org/media/uploaded/files/2016/12/10/43e84653-5955-49b6-b794-138199c53ae0__AMBARI-19117.patch


Thanks,

Xi Wang


Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54460/
-----------------------------------------------------------

(Updated Dec. 8, 2016, 4:34 p.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.


Changes
-------

Fixed UT


Bugs: AMBARI-19117
    https://issues.apache.org/jira/browse/AMBARI-19117


Repository: ambari


Description
-------

This is a FE task to implement the "Create Alerts Wizard " based on the design attached.

This task is to create Step 2 of PORT alert. see the design for details. 
Pay attention to the dependencies on selecting different options. The further fields will determined by the current selection.

eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display totally different UI.


Diffs (updated)
-----

  ambari-web/app/config.js 130cb39 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 7fb4b2d 
  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 138aaa4 
  ambari-web/app/models/alerts/alert_config.js 980dfe5 
  ambari-web/app/styles/alerts.less 77cc13c 
  ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 

Diff: https://reviews.apache.org/r/54460/diff/


Testing
-------


Thanks,

Xi Wang