You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2026/09/19 04:58:38 UTC
[PR] fix: shrink NLJ load outcome to satisfy Clippy [datafusion]
Xuanwo opened a new pull request, #25492:
URL: https://github.com/apache/datafusion/pull/25492
## Which issue does this PR close?
Minor follow-up to #25371.
## Rationale for this change
Workspace Clippy fails on main (`a522cd5bcedabd6238a0462b881a7ef4cb5c6f66`) with `clippy::large_enum_variant` in `LoadOutcome`. After the segmented batch layout change, `Chunk` contains at least 201 bytes while `Empty` carries no data.
Reproduced on aarch64 macOS with Rust 1.98.1:
```sh
cargo clippy --workspace --all-targets --all-features -- -D warnings
```
## What changes are included in this PR?
Store `Arc<JoinLeftData>` in `LoadOutcome::Chunk`. Construct the Arc when loading completes and reuse it when publishing the chunk. The successful path already allocated this Arc during publication, so this reduces the enum size without adding another allocation or changing the shared chunk ownership.
## What is the testing strategy for this PR?
The Clippy command above fails before the change and passes after it. Existing NLJ tests cover coordinated spilling, cancellation, and memory reservation lifetimes; no new behavior is introduced.
Validation:
- `cargo fmt --all`
- `cargo clippy --workspace --all-targets --all-features -- -D warnings`
- `cargo test -p datafusion-physical-plan --lib joins::nested_loop_join` (90 passed)
- `cargo test --test sqllogictests -- nested_loop_join_spill` (passed)
- `uv run ./dev/rust_lint.sh` (full suite passed)
## Are there any user-facing changes?
No query or public API changes. This restores the workspace Clippy check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: shrink NLJ load outcome to satisfy Clippy [datafusion]
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 merged PR #25492:
URL: https://github.com/apache/datafusion/pull/25492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: shrink NLJ load outcome to satisfy Clippy [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25492:
URL: https://github.com/apache/datafusion/pull/25492#issuecomment-5739637931
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25492?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.37%. Comparing base ([`a522cd5`](https://app.codecov.io/gh/apache/datafusion/commit/a522cd5bcedabd6238a0462b881a7ef4cb5c6f66?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6ced40b`](https://app.codecov.io/gh/apache/datafusion/commit/6ced40bd2d070e9c5a46342a3e780676427a8a95?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25492 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 1138 1138
Lines 433506 433505 -1
Branches 433506 433505 -1
=======================================
+ Hits 357102 357105 +3
+ Misses 54850 54842 -8
- Partials 21554 21558 +4
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25492?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org