You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michael Freedman (JIRA)" <de...@myfaces.apache.org> on 2010/01/29 17:56:34 UTC
[jira] Created: (PORTLETBRIDGE-111) Bridge RequestParamValues and
RequestHeaderValues Map don't support equals() correctly
Bridge RequestParamValues and RequestHeaderValues Map don't support equals() correctly
--------------------------------------------------------------------------------------
Key: PORTLETBRIDGE-111
URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-111
Project: MyFaces Portlet Bridge
Issue Type: Bug
Components: Impl
Affects Versions: 2.0.0-alpha, 1.0.0-beta
Reporter: Michael Freedman
Assignee: Michael Freedman
Both externalContext.getRequestParameterValues() and getRequestHeaderValues() return Maps of type <String, String[]>. If you try and compare 2 equal Maps of these using map1.equals(map2) it fails because the generic AbstractMap equals doesn't support/properly compare Arrays. Instead these Map impls (which are special internal bridge impls) must support equals directly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PORTLETBRIDGE-111) Bridge RequestParamValues and
RequestHeaderValues Map don't support equals() correctly
Posted by "Michael Freedman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Freedman resolved PORTLETBRIDGE-111.
--------------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
1.0.0
Added equals() implementation that uses Arrays.equals to compare the arrays in the values of the two Maps entries.
Also changed superclass PortletAbstractMap to extend AbstractMap rather "implement Map" -- thus other extenders (other Maps we build) can inherit regular Map equals method.
> Bridge RequestParamValues and RequestHeaderValues Map don't support equals() correctly
> --------------------------------------------------------------------------------------
>
> Key: PORTLETBRIDGE-111
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-111
> Project: MyFaces Portlet Bridge
> Issue Type: Bug
> Components: Impl
> Affects Versions: 1.0.0-beta, 2.0.0-alpha
> Reporter: Michael Freedman
> Assignee: Michael Freedman
> Fix For: 1.0.0, 2.0.0
>
>
> Both externalContext.getRequestParameterValues() and getRequestHeaderValues() return Maps of type <String, String[]>. If you try and compare 2 equal Maps of these using map1.equals(map2) it fails because the generic AbstractMap equals doesn't support/properly compare Arrays. Instead these Map impls (which are special internal bridge impls) must support equals directly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.