You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/08/02 10:39:42 UTC
[GitHub] [hive] ayushtkn commented on a change in pull request #2552: HIVE-25367: Fix TestReplicationScenariosAcidTables#testMultiDBTxn
ayushtkn commented on a change in pull request #2552:
URL: https://github.com/apache/hive/pull/2552#discussion_r680863078
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java
##########
@@ -110,10 +109,11 @@ public void runSequential() {
LOG.error("Error in executeTask", t);
}
result.setExitVal(exitVal);
- taskQueue.releaseRunnable();
if (tsk.getException() != null) {
result.setTaskError(tsk.getException());
}
+ result.setRunning(false);
+ taskQueue.releaseRunnable();
Review comment:
can we avoid all these {{result.setRunning(false)}} change and just pull {{result.setExitVal(exitVal)}} below {{result.setTaskError(tsk.getException());}}
I tried locally and it worked for me.
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/WarehouseInstance.java
##########
@@ -235,10 +235,7 @@ public WarehouseInstance run(String command) throws Throwable {
driver.run(command);
return this;
} catch (CommandProcessorException e) {
- if (e.getCause() != null) {
- throw e.getCause();
- }
- throw e;
+ throw e.getCause();
Review comment:
we need not to revert this change right? this is just a null check..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org