You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@chemistry.apache.org by "Serge Huber (JIRA)" <ji...@apache.org> on 2009/12/07 16:05:18 UTC

[jira] Created: (CMIS-73) Initial test unit for JCR sub-project

Initial test unit for JCR sub-project
-------------------------------------

                 Key: CMIS-73
                 URL: https://issues.apache.org/jira/browse/CMIS-73
             Project: Chemistry
          Issue Type: Improvement
          Components: jcr
            Reporter: Serge Huber


Here is a patch proposition for an initial test unit for the Chemistry JCR project. Unfortunately I am not an expert in cross-project sharing of test units so I had to duplicate some of the code in the Atompub-server test unit. This patch could be improved to avoid this.

Also, currently the tests do not complete because the current implementation of the jcr mapping has a lot of unsupported operations.

Nevertheless, I think it would be good to have a starting point to implement these tests, and I hope this will contribute to it.

Best regards,
  Serge Huber.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CMIS-73) Initial test unit for JCR sub-project

Posted by "Serge Huber (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CMIS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Serge Huber updated CMIS-73:
----------------------------

    Attachment: Initial_test_unit_for_JCR_mapping.patch

New TestJcrRepository unit test class.

> Initial test unit for JCR sub-project
> -------------------------------------
>
>                 Key: CMIS-73
>                 URL: https://issues.apache.org/jira/browse/CMIS-73
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Serge Huber
>         Attachments: Initial_test_unit_for_JCR_mapping.patch
>
>
> Here is a patch proposition for an initial test unit for the Chemistry JCR project. Unfortunately I am not an expert in cross-project sharing of test units so I had to duplicate some of the code in the Atompub-server test unit. This patch could be improved to avoid this.
> Also, currently the tests do not complete because the current implementation of the jcr mapping has a lot of unsupported operations.
> Nevertheless, I think it would be good to have a starting point to implement these tests, and I hope this will contribute to it.
> Best regards,
>   Serge Huber.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CMIS-73) Initial test unit for JCR sub-project

Posted by "Serge Huber (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789143#action_12789143 ] 

Serge Huber commented on CMIS-73:
---------------------------------

Hello,

Nice to know you are working on another test set, but I don't quite understand what you mean by this patch not testing anything ? It does start up a JcrRepository instance initialized with a Jackrabbit TransientRepository instance, and it tries to perform some basic CMIS operations on top of it, but it fails since the newFolder operation is not implemented by the backend.

Of course this was just a first try, I'm still learning Chemistry :)

Regards,
  Serge Huber.

> Initial test unit for JCR sub-project
> -------------------------------------
>
>                 Key: CMIS-73
>                 URL: https://issues.apache.org/jira/browse/CMIS-73
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Serge Huber
>         Attachments: Initial_test_unit_for_JCR_mapping.patch
>
>
> Here is a patch proposition for an initial test unit for the Chemistry JCR project. Unfortunately I am not an expert in cross-project sharing of test units so I had to duplicate some of the code in the Atompub-server test unit. This patch could be improved to avoid this.
> Also, currently the tests do not complete because the current implementation of the jcr mapping has a lot of unsupported operations.
> Nevertheless, I think it would be good to have a starting point to implement these tests, and I hope this will contribute to it.
> Best regards,
>   Serge Huber.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CMIS-73) Initial test unit for JCR sub-project

Posted by "Florent Guillaume (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788855#action_12788855 ] 

Florent Guillaume commented on CMIS-73:
---------------------------------------

The attached patch doesn't actually test anything about the JcrRepository implementation.
I'm working on another test set for the JCR bridge.


> Initial test unit for JCR sub-project
> -------------------------------------
>
>                 Key: CMIS-73
>                 URL: https://issues.apache.org/jira/browse/CMIS-73
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Serge Huber
>         Attachments: Initial_test_unit_for_JCR_mapping.patch
>
>
> Here is a patch proposition for an initial test unit for the Chemistry JCR project. Unfortunately I am not an expert in cross-project sharing of test units so I had to duplicate some of the code in the Atompub-server test unit. This patch could be improved to avoid this.
> Also, currently the tests do not complete because the current implementation of the jcr mapping has a lot of unsupported operations.
> Nevertheless, I think it would be good to have a starting point to implement these tests, and I hope this will contribute to it.
> Best regards,
>   Serge Huber.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CMIS-73) Initial test unit for JCR sub-project

Posted by "Florent Guillaume (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CMIS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florent Guillaume resolved CMIS-73.
-----------------------------------

    Resolution: Fixed

> Initial test unit for JCR sub-project
> -------------------------------------
>
>                 Key: CMIS-73
>                 URL: https://issues.apache.org/jira/browse/CMIS-73
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Serge Huber
>         Attachments: Initial_test_unit_for_JCR_mapping.patch
>
>
> Here is a patch proposition for an initial test unit for the Chemistry JCR project. Unfortunately I am not an expert in cross-project sharing of test units so I had to duplicate some of the code in the Atompub-server test unit. This patch could be improved to avoid this.
> Also, currently the tests do not complete because the current implementation of the jcr mapping has a lot of unsupported operations.
> Nevertheless, I think it would be good to have a starting point to implement these tests, and I hope this will contribute to it.
> Best regards,
>   Serge Huber.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CMIS-73) Initial test unit for JCR sub-project

Posted by "Florent Guillaume (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789433#action_12789433 ] 

Florent Guillaume commented on CMIS-73:
---------------------------------------

I've committed a testcase as of r889742

But the tests don't pass today (and are disabled in the POM), because folder/document doesn't seem to work.
In JcrNewFolder for instance, save() tries to do a:
            node.addMixin("mix:unstructured");
which doesn't work as this mixin is not defined.
The creation/mapping model of CMIS to JCR has to be defined clearly and implemented, because I think today only the read case has been taken into account.

I'm closing this issue, new issues should be opened when someone works on the JCR code itself.


> Initial test unit for JCR sub-project
> -------------------------------------
>
>                 Key: CMIS-73
>                 URL: https://issues.apache.org/jira/browse/CMIS-73
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Serge Huber
>         Attachments: Initial_test_unit_for_JCR_mapping.patch
>
>
> Here is a patch proposition for an initial test unit for the Chemistry JCR project. Unfortunately I am not an expert in cross-project sharing of test units so I had to duplicate some of the code in the Atompub-server test unit. This patch could be improved to avoid this.
> Also, currently the tests do not complete because the current implementation of the jcr mapping has a lot of unsupported operations.
> Nevertheless, I think it would be good to have a starting point to implement these tests, and I hope this will contribute to it.
> Best regards,
>   Serge Huber.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CMIS-73) Initial test unit for JCR sub-project

Posted by "Florent Guillaume (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790133#action_12790133 ] 

Florent Guillaume commented on CMIS-73:
---------------------------------------

Sorry Serge, I meant that the patch you have actually tests AtomPub client -> AtomPub server -> JCR backend, which is quite overkill for what's needed. Anyway I've committed a simpler way to do the tests but the actual JCR code still needs work.


> Initial test unit for JCR sub-project
> -------------------------------------
>
>                 Key: CMIS-73
>                 URL: https://issues.apache.org/jira/browse/CMIS-73
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Serge Huber
>         Attachments: Initial_test_unit_for_JCR_mapping.patch
>
>
> Here is a patch proposition for an initial test unit for the Chemistry JCR project. Unfortunately I am not an expert in cross-project sharing of test units so I had to duplicate some of the code in the Atompub-server test unit. This patch could be improved to avoid this.
> Also, currently the tests do not complete because the current implementation of the jcr mapping has a lot of unsupported operations.
> Nevertheless, I think it would be good to have a starting point to implement these tests, and I hope this will contribute to it.
> Best regards,
>   Serge Huber.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.