You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zk-drizzle (via GitHub)" <gi...@apache.org> on 2023/05/08 07:21:17 UTC

[GitHub] [rocketmq] zk-drizzle commented on a diff in pull request #6507: [ISSUE #6336] [RIP-62] Cold Read Control

zk-drizzle commented on code in PR #6507:
URL: https://github.com/apache/rocketmq/pull/6507#discussion_r1187111607


##########
store/src/main/java/org/apache/rocketmq/store/util/LibC.java:
##########
@@ -50,4 +52,8 @@ public interface LibC extends Library {
     int mlockall(int flags);
 
     int msync(Pointer p, NativeLong length, int flags);
+
+    int mincore(Pointer p, NativeLong length, byte[] vec);

Review Comment:
   First of all, thank you very much for your review and reply. The MappedByteBuffer#isLoaded0 method was also considered early on to solve this problem, but the granularity of this method is a little somewhat broad (it only returns true if all pages of the detected block of data are in physical memory).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org