[GitHub] [lucene-solr] dweiss commented on a change in pull request #2229: LUCENE-9688: Hunspell: consider prefix's continuation flags when applying suffix

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2229:
URL: https://github.com/apache/lucene-solr/pull/2229#discussion_r562462937



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java
##########
@@ -588,6 +585,12 @@ private boolean checkCondition(
     return stems;
   }
 
+  private boolean isFlagAppendedByAffix(int affixId, char flag) {
+    if (affixId < 0) return false;

Review comment:
       Add curly braces. I know, it's verbose but some folks on this list even went as far as to require it (the formatter doesn't care).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org