You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/03/02 15:42:47 UTC

[GitHub] [kylin] zhengshengjun commented on a change in pull request #1593: KYLIN-4910 Return hostname as Sparder URL address when spark master is set to local

zhengshengjun commented on a change in pull request #1593:
URL: https://github.com/apache/kylin/pull/1593#discussion_r585675172



##########
File path: kylin-spark-project/kylin-spark-query/src/main/scala/org/apache/spark/sql/SparderContext.scala
##########
@@ -174,7 +175,7 @@ object SparderContext extends Logging {
               initMonitorEnv()
               master match {
                 case mode: String if mode.startsWith("local") =>
-                  master_app_url = "http://localhost:" + sparkSession.sparkContext.getConf
+                  master_app_url = "http://" + ToolUtil.getHostName + ":" + sparkSession.sparkContext.getConf

Review comment:
       thanks, It's a considerable advice !




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org