You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/01 10:57:17 UTC
[GitHub] [bookkeeper] Technoboy- opened a new pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Technoboy- opened a new pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406
Fix #2405 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#issuecomment-684780006
I am not sure I follow, the microbenchmarks is not intended to have an impact on the bookie service.
Do you have a stacktrace to share ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Technoboy- commented on pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#issuecomment-684784829
> I am not sure I follow, the microbenchmarks is not intended to have an impact on the bookie service.
> Do you have a stacktrace to share ?
From this [wiki](http://www.slf4j.org/codes.html#log4jDelegationLoop), it suggests not to keep the two jar together.
If we run Bookie locally, two jars are all in the classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Technoboy- closed pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Technoboy- commented on a change in pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#discussion_r481080574
##########
File path: pom.xml
##########
@@ -251,11 +251,6 @@
<artifactId>slf4j-log4j12</artifactId>
<version>${slf4j.version}</version>
</dependency>
- <dependency>
Review comment:
Yes, I know. But it's really occurs in my local and do not reproduce after retry.
Well, it is also ambiguous to declare the two.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#discussion_r481077218
##########
File path: pom.xml
##########
@@ -251,11 +251,6 @@
<artifactId>slf4j-log4j12</artifactId>
<version>${slf4j.version}</version>
</dependency>
- <dependency>
Review comment:
this is inside "<dependencyManagement>" section, it it only a declaration of the version, it is not using the jar
see
https://stackoverflow.com/questions/2619598/differences-between-dependencymanagement-and-dependencies-in-maven
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Technoboy- commented on pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#issuecomment-684792283
> You change does not affect the list of jars on the classpath, because you modified only the 'microbenchmarks' module, that is not a source for the 'bookie' service.
I have removed the dependency of log4j-over-slf4j.jar in the parent pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Technoboy- commented on pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#issuecomment-684778191
> Did it happen only on microbenchmarks ?
> Interesting
Yes. And if we start bookie locally, it will throw the error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#issuecomment-684775796
Did it happen only on microbenchmarks ?
Interesting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Technoboy- commented on a change in pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#discussion_r481080850
##########
File path: pom.xml
##########
@@ -251,11 +251,6 @@
<artifactId>slf4j-log4j12</artifactId>
<version>${slf4j.version}</version>
</dependency>
- <dependency>
Review comment:
Should I close this pr ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#issuecomment-684789672
You change does not affect the list of jars on the classpath, because you modified only the 'microbenchmarks' module, that is not a source for the 'bookie' service.
In fact we have an automatic check that checks every jar in the binary tarball and detects if there is a companion LICENSE file.
If your change drops a jar from the classpath of the bookie (and so it is no more present in the .tar.gz file) I expect that check to fail because we did not update the list of LICENSE files.
Can you please verify in the two .tar.gz files created inside bookkeeper-dist/server and bookkeeper-dist/all modules that the jar was present before the patch and it is now no more present ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Technoboy- commented on pull request #2406: Fix Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #2406:
URL: https://github.com/apache/bookkeeper/pull/2406#issuecomment-684801608
Should I close this pr ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org