You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2019/11/04 21:00:55 UTC

[thrift] branch master updated: THRIFT-4994 changed this to self in forEach callback Client: nodejs Patch: Eugen Kandakov

This is an automated email from the ASF dual-hosted git repository.

jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new f7b2197  THRIFT-4994 changed this to self in forEach callback Client: nodejs Patch: Eugen Kandakov
f7b2197 is described below

commit f7b219791653d206a03d236e2bd69e79c4d4a392
Author: Eugen Kandakov <ka...@gmail.com>
AuthorDate: Mon Nov 4 13:15:35 2019 +0100

    THRIFT-4994 changed this to self in forEach callback
    Client: nodejs
    Patch: Eugen Kandakov
    
    This closes #1918
---
 lib/nodejs/lib/thrift/ws_transport.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/nodejs/lib/thrift/ws_transport.js b/lib/nodejs/lib/thrift/ws_transport.js
index 3513b84..4cf62b9 100644
--- a/lib/nodejs/lib/thrift/ws_transport.js
+++ b/lib/nodejs/lib/thrift/ws_transport.js
@@ -83,8 +83,8 @@ TWebSocketTransport.prototype.__onOpen = function() {
       //If the user made calls before the connection was fully
       //open, send them now
       this.send_pending.forEach(function(elem) {
-         this.socket.send(elem.buf);
-         this.callbacks.push((function() {
+         self.socket.send(elem.buf);
+         self.callbacks.push((function() {
            var clientCallback = elem.cb;
            return function(msg) {
               self.setRecvBuffer(msg);