You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2017/05/11 23:22:30 UTC
Review Request 59212: SENTRY-1763 Fix the config string for server
load balancing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59212/
-----------------------------------------------------------
Review request for sentry and Alexander Kolbasov.
Bugs: SENTRY-1763
https://issues.apache.org/jira/browse/SENTRY-1763
Repository: sentry
Description
-------
There is a extra space in the config string with this issue configuration will not match and always default behavior is seen.
Diffs
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java c0768f9
Diff: https://reviews.apache.org/r/59212/diff/1/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 59212: SENTRY-1763 Fix the config string for
server load balancing
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59212/#review174814
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On May 11, 2017, 11:22 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59212/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 11:22 p.m.)
>
>
> Review request for sentry and Alexander Kolbasov.
>
>
> Bugs: SENTRY-1763
> https://issues.apache.org/jira/browse/SENTRY-1763
>
>
> Repository: sentry
>
>
> Description
> -------
>
> There is a extra space in the config string with this issue configuration will not match and always default behavior is seen.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java c0768f9
>
>
> Diff: https://reviews.apache.org/r/59212/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 59212: SENTRY-1763 Fix the config string for
server load balancing
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On May 12, 2017, 3:06 p.m., Na Li wrote:
> > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java
> > Line 104 (original), 104 (patched)
> > <https://reviews.apache.org/r/59212/diff/1/?file=1716299#file1716299line104>
> >
> > Where is "sentry.service.client.connection.loadbalance" used to configure the client? Is it in testing script? I cannot find it.
> >
> > If the caller and the execution both use SENTRY_CLIENT_LOAD_BALANCING, then we don't have this issue.
It is the configuration that has to be configured for the clients to akip load balancing. "sentry.service.client.connection.loadbalance" is configured in config files which sentry clients read. With out this fix the client will look for " sentry.service.client.connection.loadbalance" in the config file and will never find the configuration.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59212/#review174795
-----------------------------------------------------------
On May 11, 2017, 11:22 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59212/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 11:22 p.m.)
>
>
> Review request for sentry and Alexander Kolbasov.
>
>
> Bugs: SENTRY-1763
> https://issues.apache.org/jira/browse/SENTRY-1763
>
>
> Repository: sentry
>
>
> Description
> -------
>
> There is a extra space in the config string with this issue configuration will not match and always default behavior is seen.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java c0768f9
>
>
> Diff: https://reviews.apache.org/r/59212/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 59212: SENTRY-1763 Fix the config string for
server load balancing
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59212/#review174795
-----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java
Line 104 (original), 104 (patched)
<https://reviews.apache.org/r/59212/#comment248017>
Where is "sentry.service.client.connection.loadbalance" used to configure the client? Is it in testing script? I cannot find it.
If the caller and the execution both use SENTRY_CLIENT_LOAD_BALANCING, then we don't have this issue.
- Na Li
On May 11, 2017, 11:22 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59212/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 11:22 p.m.)
>
>
> Review request for sentry and Alexander Kolbasov.
>
>
> Bugs: SENTRY-1763
> https://issues.apache.org/jira/browse/SENTRY-1763
>
>
> Repository: sentry
>
>
> Description
> -------
>
> There is a extra space in the config string with this issue configuration will not match and always default behavior is seen.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java c0768f9
>
>
> Diff: https://reviews.apache.org/r/59212/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>