[GitHub] [airflow] ashb commented on a change in pull request #18800: Make the salesforce connection initiation more robust

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #18800:
URL: https://github.com/apache/airflow/pull/18800#discussion_r727848837



##########
File path: tests/providers/salesforce/hooks/test_salesforce.py
##########
@@ -88,17 +88,17 @@ def test_get_conn_password_auth(self, mock_salesforce):
             password=password_auth_conn.password,
             security_token=extras["extra__salesforce__security_token"],
             domain=extras["extra__salesforce__domain"],
-            session_id=None,
-            instance=None,
-            instance_url=None,
-            organizationId=None,
+            session_id='',
+            instance='',
+            instance_url='',
+            organizationId='',

Review comment:
       I have a feeling that this change would break existing Salesforce connections, since previously you had to specify the values as empty strings, but now passing these values to Salesforce sa `''` instead of None _might_ break things?
   
   Not that familiar with the SF hooks so could be wrong!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org