You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/05 11:23:16 UTC

[GitHub] [incubator-inlong] healchow commented on a change in pull request #2938: [INLONG-2930][Manager] Add ClickHouse sink support in manager client

healchow commented on a change in pull request #2938:
URL: https://github.com/apache/incubator-inlong/pull/2938#discussion_r820085617



##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/util/InlongStreamSinkTransfer.java
##########
@@ -50,6 +55,9 @@ public static SinkRequest createSinkRequest(StreamSink streamSink, InlongStreamI
         if (sinkType == SinkType.KAFKA) {
             return createKafkaRequest(streamSink, streamInfo);
         }
+        if (sinkType == SinkType.CLICKHOUSE) {

Review comment:
       Please use `else if` statement.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org