You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (JIRA)" <ji...@apache.org> on 2015/11/26 01:56:10 UTC
[jira] [Commented] (HBASE-14886) ReplicationAdmin does not use full
peer configuration
[ https://issues.apache.org/jira/browse/HBASE-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027918#comment-15027918 ]
Elliott Clark commented on HBASE-14886:
---------------------------------------
Would this same change apply to just about everywhere that applyClusterKeyToConf is used ?
> ReplicationAdmin does not use full peer configuration
> -----------------------------------------------------
>
> Key: HBASE-14886
> URL: https://issues.apache.org/jira/browse/HBASE-14886
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Critical
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: hbase-14886-v1.patch, hbase-14886.patch
>
>
> In {{listValidReplicationPeers()}}, we're creating the peer {{Configuration}} based on the source connection configuration and simply applying the peer ZK cluster key. This causes any additional properties present in the {{ReplicationPeerConfig}} configuration to not be applied.
> We should instead be using the configuration returned by {{ReplicationPeers.getPeerConf()}}, which we already call in that method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)