You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2024/09/03 13:42:56 UTC
[PR] feat(trait): Move addon AWS Secrets Manager to traits [camel-k]
gansheer opened a new pull request, #5812:
URL: https://github.com/apache/camel-k/pull/5812
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): Move addon AWS Secrets Manager to traits [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer closed pull request #5812: feat(trait): Move addon AWS Secrets Manager to traits
URL: https://github.com/apache/camel-k/pull/5812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): Move addon AWS Secrets Manager to traits [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #5812:
URL: https://github.com/apache/camel-k/pull/5812#issuecomment-2327086199
I am closing this draft PR now that I have the feedback I needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): Move addon AWS Secrets Manager to traits [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #5812:
URL: https://github.com/apache/camel-k/pull/5812#issuecomment-2326723373
> LGTM. Since you are there, you should be aware of this proposal #5258
>
> It could be good if we manage to have a single trait for the vaults addons and then the trait specify each provider logic.
For now I would like to concentrate on the refactoring since some of the addons (keda and strimzi) looks a little more tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org