[jira] Commented: (HARMONY-3065) [DRLVM][hy_thr] Force inline of p_TLS_vmthread and tmn_suspent_enable/disable.

["Rana Dasgupta (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477551 ] 

Rana Dasgupta commented on HARMONY-3065:
----------------------------------------

1)
>mov ax, [edx]HyThread.suspend_disable_count 
>dec eax 
>test eax, eax 

right, that's a typo' ...good catch 

movzx eax, [edx]HyThread.suspend_disable_count //disable_count is 16 bits


2)
>like "mov ECX, [EBP]-12".... Can the following lines simply be deleted? 

no locals, so frame setup not needed


>push ebp 
>mov ebp, esp 

>move esp, ebp 
>pop ebp

it is just preference, i like saving esp in a native call because I don't know what conventions I will call out into. In this case, you can remove these, but then you will need to uncomment "pop edx" after calling thread_safe_point_impl




> [DRLVM][hy_thr] Force inline of p_TLS_vmthread and tmn_suspent_enable/disable.
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-3065
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3065
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Pavel Afremov
>         Assigned To: weldon washburn
>         Attachments: 0001-Adapt-TLS-inlining-for-Linux.txt, 0001-Force-inline-of-p_TLS_vmthread-and-tmn_suspent_enable-disable.patch, 0001-Force-inline-of-p_TLS_vmthread-and-tmn_suspent_enable-disable.patch, 0001-Force-inline-of-p_TLS_vmthread-and-tmn_suspent_enable-disable.txt, JNIExceptionPerf.zip, nativecalls.patch
>
>
> Force inline of p_TLS_vmthread and tmn_suspent_enable/disable. It improve performance up to 3 times.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.