You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/05/10 17:16:26 UTC
[Impala-ASF-CR] IMPALA-10684: Report invalid parameter setting errors during HS2 OpenSession
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17363 )
Change subject: IMPALA-10684: Report invalid parameter setting errors during HS2 OpenSession
......................................................................
Patch Set 1:
(3 comments)
Let me see if I understand this:
A session logs on with bad query options. Right now, nothing is returned to the client at OpenSession. If that session runs a query, what happens? Does it throw an error about the invalid query options? Or does it silently try to run with invalid query options?
I'm trying to decide whether it makes sense to enforce this at OpenSession or whether it would be better to wait until running a SQL. If existing users currently open a session with invalid parameters, then this would be a behavior change.
http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/common/status.h
File be/src/common/status.h:
http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/common/status.h@164
PS1, Line 164: // Same as Status(string) but can supress logging
: Status(const std::string& error_msg, bool silent);
The "Expected" constructors are equivalent to the usual constructors with silent=true. So, let's switch to using that and leaving this private.
http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/common/status.h@183
PS1, Line 183: static Status Expected(const std::string& error_msg);
This is equivalent to silent=true.
http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:
http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/service/impala-hs2-server.cc@364
PS1, Line 364: // Ignore failure (failures will be logged in SetQueryOption()).
Update this comment.
--
To view, visit http://gerrit.cloudera.org:8080/17363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a859bf5226feb903017a66f199ca5da916f217
Gerrit-Change-Number: 17363
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 May 2021 17:16:26 +0000
Gerrit-HasComments: Yes