You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/04 11:45:57 UTC

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3774: [Doris On ES] Add ES QueryBuilders for debug mode

wuyunfeng opened a new pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] kangkaisen merged pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] kangkaisen commented on pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-641006446


   @wuyunfeng Hiļ¼ŒThis PR is ready to merge?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] wuyunfeng edited a comment on pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

Posted by GitBox <gi...@apache.org>.
wuyunfeng edited a comment on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-640437869


   Sorry for leave some file which use elasticsearch related still reference the before source file path. 
   All related elasticsearch test file put in the same package with source to use the `package-private` method


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] wuyunfeng commented on pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-640479346


   `EsStateStoreTest` do some test based on `cluster state`, `Doris On ES` will not request `_cluster/state` in the future 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] wuyunfeng commented on pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-640437869


   Sorry for leave some file which use elasticsearch related still reference the before source file path


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] wuyunfeng edited a comment on pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

Posted by GitBox <gi...@apache.org>.
wuyunfeng edited a comment on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-640479346


   `EsStateStoreTest` do some test based on `cluster state`, `Doris On ES` will not request `_cluster/state` in the future. 
   Another PR work in this (WIP)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] wuyunfeng edited a comment on pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

Posted by GitBox <gi...@apache.org>.
wuyunfeng edited a comment on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-640437869


   Sorry for leaving some file which use elasticsearch related still reference the before source file path. 
   All related elasticsearch test file put in the same package with source to use the `package-private` method


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman commented on pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-639946359


   hi @wuyunfeng Plz resolve the conflict.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] wuyunfeng commented on pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on pull request #3774:
URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-641092988


   @kangkaisen  Yes,  can you help me to merge this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org