[GitHub] zeppelin pull request #2281: added principalSuffix to AD examples

[paul-brenner <gi...@git.apache.org>]

GitHub user paul-brenner opened a pull request:

    https://github.com/apache/zeppelin/pull/2281

    added principalSuffix to AD examples

    ### What is this PR for?
    Documentation - Adding an example use of prinicpalSuffix to the Active Directory authentication documentation. It took us a while to figure out that the lack of a principalSuffix was our problem and then a bit more hunting to figure out how to automatically include it 
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
    
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-brenner/zeppelin patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2281
    
----
commit 2ff57a99033aa23b334eade8d644fa9d4b915144
Author: Paul Brenner <pa...@users.noreply.github.com>
Date:   2017-04-24T21:35:04Z

    added principalSuffix to AD examples

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2281: added principalSuffix to AD examples

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2281


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2281: added principalSuffix to AD examples

[Leemoonsoo <gi...@git.apache.org>]

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2281
  
    Thanks @paul-brenner for the contribution!
    
    LGTM and merge to master and branch-0.7 if no further discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---