You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/01/07 00:30:06 UTC
Re: Review Request 29137: Implementing dual read the
PopulatedJobConfig struct
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 11:30 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
-kevints
+wfarner
Bugs: AURORA-691
https://issues.apache.org/jira/browse/AURORA-691
Repository: aurora
Description
-------
Dual reading populated configs to make sure we are backwards compatible by 0.8.0.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/updater.py 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e
src/main/python/apache/aurora/client/base.py 258c1fa87645ec48854198529392c84ae08c93be
src/main/python/apache/aurora/client/cli/jobs.py 8bdb7f488f68b10b767ced627e55e57698e4f5f2
src/main/python/apache/aurora/client/commands/core.py cbaa67a78533fedf679eb993c9deb0f09b705616
src/test/python/apache/aurora/client/api/test_updater.py dad69e20598c1daf62706989dafcb4be50fed82b
src/test/python/apache/aurora/client/cli/test_diff.py d8da68fef7603e0da5f53c059367541d971bda50
src/test/python/apache/aurora/client/cli/test_restart.py c19b21dd99dded0fdc631cef90997e2f2bd1156e
src/test/python/apache/aurora/client/cli/test_update.py 044e6099a81bfa241a317b6a6b0f6f46da49bdc2
src/test/python/apache/aurora/client/commands/test_diff.py 8e346ed3e6b8c91a7882029cd0734bd55165c479
src/test/python/apache/aurora/client/commands/test_restart.py 3789f3bd9ea2753070c966e0b755ab2168f7dd05
src/test/python/apache/aurora/client/commands/test_update.py 3f5f83e75d287984a926ccf1c4fe2ad0d362b036
src/test/python/apache/aurora/client/test_base.py fba08aeb8103aaa62fb86c389a1976f89289a086
Diff: https://reviews.apache.org/r/29137/diff/
Testing
-------
./pants src/test/python/apache/aurora/client:all
Verified in vagrant.
Thanks,
Maxim Khutornenko
Re: Review Request 29137: Implementing dual read the
PopulatedJobConfig struct
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review66952
-----------------------------------------------------------
Ship it!
Master (8c49029) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 6, 2015, 11:30 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29137/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 11:30 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-691
> https://issues.apache.org/jira/browse/AURORA-691
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dual reading populated configs to make sure we are backwards compatible by 0.8.0.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/updater.py 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e
> src/main/python/apache/aurora/client/base.py 258c1fa87645ec48854198529392c84ae08c93be
> src/main/python/apache/aurora/client/cli/jobs.py 8bdb7f488f68b10b767ced627e55e57698e4f5f2
> src/main/python/apache/aurora/client/commands/core.py cbaa67a78533fedf679eb993c9deb0f09b705616
> src/test/python/apache/aurora/client/api/test_updater.py dad69e20598c1daf62706989dafcb4be50fed82b
> src/test/python/apache/aurora/client/cli/test_diff.py d8da68fef7603e0da5f53c059367541d971bda50
> src/test/python/apache/aurora/client/cli/test_restart.py c19b21dd99dded0fdc631cef90997e2f2bd1156e
> src/test/python/apache/aurora/client/cli/test_update.py 044e6099a81bfa241a317b6a6b0f6f46da49bdc2
> src/test/python/apache/aurora/client/commands/test_diff.py 8e346ed3e6b8c91a7882029cd0734bd55165c479
> src/test/python/apache/aurora/client/commands/test_restart.py 3789f3bd9ea2753070c966e0b755ab2168f7dd05
> src/test/python/apache/aurora/client/commands/test_update.py 3f5f83e75d287984a926ccf1c4fe2ad0d362b036
> src/test/python/apache/aurora/client/test_base.py fba08aeb8103aaa62fb86c389a1976f89289a086
>
> Diff: https://reviews.apache.org/r/29137/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client:all
> Verified in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 29137: Implementing dual read the
PopulatedJobConfig struct
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review67069
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 6, 2015, 11:30 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29137/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 11:30 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-691
> https://issues.apache.org/jira/browse/AURORA-691
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dual reading populated configs to make sure we are backwards compatible by 0.8.0.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/updater.py 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e
> src/main/python/apache/aurora/client/base.py 258c1fa87645ec48854198529392c84ae08c93be
> src/main/python/apache/aurora/client/cli/jobs.py 8bdb7f488f68b10b767ced627e55e57698e4f5f2
> src/main/python/apache/aurora/client/commands/core.py cbaa67a78533fedf679eb993c9deb0f09b705616
> src/test/python/apache/aurora/client/api/test_updater.py dad69e20598c1daf62706989dafcb4be50fed82b
> src/test/python/apache/aurora/client/cli/test_diff.py d8da68fef7603e0da5f53c059367541d971bda50
> src/test/python/apache/aurora/client/cli/test_restart.py c19b21dd99dded0fdc631cef90997e2f2bd1156e
> src/test/python/apache/aurora/client/cli/test_update.py 044e6099a81bfa241a317b6a6b0f6f46da49bdc2
> src/test/python/apache/aurora/client/commands/test_diff.py 8e346ed3e6b8c91a7882029cd0734bd55165c479
> src/test/python/apache/aurora/client/commands/test_restart.py 3789f3bd9ea2753070c966e0b755ab2168f7dd05
> src/test/python/apache/aurora/client/commands/test_update.py 3f5f83e75d287984a926ccf1c4fe2ad0d362b036
> src/test/python/apache/aurora/client/test_base.py fba08aeb8103aaa62fb86c389a1976f89289a086
>
> Diff: https://reviews.apache.org/r/29137/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client:all
> Verified in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>