You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mm...@apache.org on 2007/02/15 16:11:29 UTC
svn commit: r507954 -
/myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java
Author: mmarinschek
Date: Thu Feb 15 07:11:28 2007
New Revision: 507954
URL: http://svn.apache.org/viewvc?view=rev&rev=507954
Log:
added a remove before the set-statement in ThreadLocal - with a client, memory leaks have been detected on certain platforms if this is not done
Modified:
myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java
Modified: myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java?view=diff&rev=507954&r1=507953&r2=507954
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java Thu Feb 15 07:11:28 2007
@@ -84,6 +84,7 @@
protected static void setCurrentInstance(javax.faces.context.FacesContext context)
{
+ _currentInstance.remove();
_currentInstance.set(context);
}
Re: svn commit: r507954 - /myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java
Posted by Martin Marinschek <ma...@gmail.com>.
oh no...
thanks for the heads up!
regards,
Martin
On 2/15/07, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi Martin!
> > --- myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java (original)
> > +++ myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java Thu Feb 15 07:11:28 2007
> > @@ -84,6 +84,7 @@
> >
> > protected static void setCurrentInstance(javax.faces.context.FacesContext context)
> > {
> > + _currentInstance.remove();
> > _currentInstance.set(context);
> >
> ThreadLocal.remove() is jdk 1.5 only!
>
> Ciao,
> Mario
>
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: svn commit: r507954 - /myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi Martin!
> --- myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java (original)
> +++ myfaces/core/trunk/api/src/main/java/javax/faces/context/FacesContext.java Thu Feb 15 07:11:28 2007
> @@ -84,6 +84,7 @@
>
> protected static void setCurrentInstance(javax.faces.context.FacesContext context)
> {
> + _currentInstance.remove();
> _currentInstance.set(context);
>
ThreadLocal.remove() is jdk 1.5 only!
Ciao,
Mario