You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "yamasakisua (via GitHub)" <gi...@apache.org> on 2024/06/15 14:12:58 UTC
[PR] BITOP-4128: Docker compose plugin doesn't have '-v' option [bigtop]
yamasakisua opened a new pull request, #1281:
URL: https://github.com/apache/bigtop/pull/1281
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
https://issues.apache.org/jira/browse/BIGTOP-4128
### How was this patch tested?
```
$./docker-hadoop.sh -dcp -c 3
Environment check...
Check docker:Environment check...
Check docker:
Docker version 26.1.3, build b72abbb
Check docker-compose:
Docker Compose version v2.27.0
Check ruby:
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu]
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BITOP-4128: Docker compose plugin doesn't have '-v' option [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on code in PR #1281:
URL: https://github.com/apache/bigtop/pull/1281#discussion_r1642613544
##########
provisioner/docker/docker-hadoop.sh:
##########
@@ -271,7 +271,11 @@ env-check() {
echo "Check docker:"
docker -v || exit 1
echo "Check docker-compose:"
- $DOCKER_COMPOSE_CMD -v || exit 1
+ if [ "$DOCKER_COMPOSE_CMD" == "docker-compose" ]; then
+ $DOCKER_COMPOSE_CMD -v || exit 1
+ elif [ "$DOCKER_COMPOSE_CMD" == "docker compose" ]; then
+ $DOCKER_COMPOSE_CMD version || exit 1
+ fi
Review Comment:
@yamasakisua basically LGTM.
- Could you replace tabs with whitespaces?
- Could you remove a trailing whitespace in line 278?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BITOP-4128: Docker compose plugin doesn't have '-v' option [bigtop]
Posted by "yamasakisua (via GitHub)" <gi...@apache.org>.
yamasakisua commented on PR #1281:
URL: https://github.com/apache/bigtop/pull/1281#issuecomment-2176008314
@iwasakims
Thanks for the comment.
I fixed tabs and align indent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org