[GitHub] [accumulo] keith-turner commented on a change in pull request #1025: Fix lgtm dead logic alerts

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1025: Fix lgtm dead logic alerts
URL: https://github.com/apache/accumulo/pull/1025#discussion_r264706862
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
 ##########
 @@ -2425,9 +2425,6 @@ public void importMapFiles(long tid, Map<FileRef,MapFileInfo> fileMap, boolean s
       }
     } finally {
       synchronized (this) {
-        if (writesInProgress < 1)
 
 Review comment:
   I think these checks should be left as-is. It may not be possible to for the current code result in this condition, but changes in the code could cause the assumptions to be violated.  If that happens it would be nice to have the checks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services