You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/23 06:46:42 UTC
[GitHub] [rocketmq] RongtongJin commented on a change in pull request #2832: [ISSUE #2732] Fix message loss problem when rebalance with LitePullConsumer
RongtongJin commented on a change in pull request #2832:
URL: https://github.com/apache/rocketmq/pull/2832#discussion_r618977101
##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/AssignedMessageQueue.java
##########
@@ -83,10 +83,15 @@ public long getPullOffset(MessageQueue messageQueue) {
return -1;
}
- public void updatePullOffset(MessageQueue messageQueue, long offset) {
+ public void updatePullOffset(MessageQueue messageQueue, long offset, ProcessQueue processQueue) {
MessageQueueState messageQueueState = assignedMessageQueueState.get(messageQueue);
Review comment:
If return null here, it may report to NPE.
##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/AssignedMessageQueue.java
##########
@@ -83,10 +83,15 @@ public long getPullOffset(MessageQueue messageQueue) {
return -1;
}
- public void updatePullOffset(MessageQueue messageQueue, long offset) {
+ public void updatePullOffset(MessageQueue messageQueue, long offset, ProcessQueue processQueue) {
MessageQueueState messageQueueState = assignedMessageQueueState.get(messageQueue);
- if (messageQueueState != null) {
- messageQueueState.setPullOffset(offset);
+ synchronized (this.assignedMessageQueueState) {
+ if (messageQueueState.getProcessQueue() != processQueue) {
+ return;
+ }
+ if (messageQueueState != null) {
+ messageQueueState.setPullOffset(offset);
+ }
}
Review comment:
Synchronized here seems to be unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org