You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/01/04 19:48:01 UTC
[kudu-CR] Rename ts location assignment-itest to location assignment-itest
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12161
Change subject: Rename ts_location_assignment-itest to location_assignment-itest
......................................................................
Rename ts_location_assignment-itest to location_assignment-itest
The following patch will add client location assignment tests to this
file, and renaming it now makes it easier to review.
Change-Id: I50e3bed6e8cc8aa08877037b1f9a0f7230009e58
---
A src/kudu/integration-tests/location_assignment-itest.cc
D src/kudu/integration-tests/ts_location_assignment-itest.cc
2 files changed, 228 insertions(+), 132 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/12161/1
--
To view, visit http://gerrit.cloudera.org:8080/12161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50e3bed6e8cc8aa08877037b1f9a0f7230009e58
Gerrit-Change-Number: 12161
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Rename ts location assignment-itest to location assignment-itest
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12161 )
Change subject: Rename ts_location_assignment-itest to location_assignment-itest
......................................................................
Patch Set 1:
> Looks like this is missing a CMakeLists.txt change.
:facepalm:
--
To view, visit http://gerrit.cloudera.org:8080/12161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50e3bed6e8cc8aa08877037b1f9a0f7230009e58
Gerrit-Change-Number: 12161
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 04 Jan 2019 22:06:02 +0000
Gerrit-HasComments: No
[kudu-CR] Rename ts location assignment-itest to location assignment-itest
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12161 )
Change subject: Rename ts_location_assignment-itest to location_assignment-itest
......................................................................
Rename ts_location_assignment-itest to location_assignment-itest
The following patch will add client location assignment tests to this
file, and renaming it now makes it easier to review.
Change-Id: I50e3bed6e8cc8aa08877037b1f9a0f7230009e58
Reviewed-on: http://gerrit.cloudera.org:8080/12161
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/location_assignment-itest.cc
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I50e3bed6e8cc8aa08877037b1f9a0f7230009e58
Gerrit-Change-Number: 12161
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Rename ts location assignment-itest to location assignment-itest
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12161 )
Change subject: Rename ts_location_assignment-itest to location_assignment-itest
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50e3bed6e8cc8aa08877037b1f9a0f7230009e58
Gerrit-Change-Number: 12161
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Jan 2019 22:05:58 +0000
Gerrit-HasComments: No
[kudu-CR] Rename ts location assignment-itest to location assignment-itest
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12161
to look at the new patch set (#2).
Change subject: Rename ts_location_assignment-itest to location_assignment-itest
......................................................................
Rename ts_location_assignment-itest to location_assignment-itest
The following patch will add client location assignment tests to this
file, and renaming it now makes it easier to review.
Change-Id: I50e3bed6e8cc8aa08877037b1f9a0f7230009e58
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/location_assignment-itest.cc
2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/12161/2
--
To view, visit http://gerrit.cloudera.org:8080/12161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50e3bed6e8cc8aa08877037b1f9a0f7230009e58
Gerrit-Change-Number: 12161
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Rename ts location assignment-itest to location assignment-itest
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12161 )
Change subject: Rename ts_location_assignment-itest to location_assignment-itest
......................................................................
Patch Set 1:
Looks like this is missing a CMakeLists.txt change.
--
To view, visit http://gerrit.cloudera.org:8080/12161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50e3bed6e8cc8aa08877037b1f9a0f7230009e58
Gerrit-Change-Number: 12161
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Jan 2019 20:08:02 +0000
Gerrit-HasComments: No