You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2021/06/23 09:14:39 UTC
[GitHub] [maven-site] rjmunro opened a new pull request #240: Use an SPDX identifier in example, as recommended
rjmunro opened a new pull request #240:
URL: https://github.com/apache/maven-site/pull/240
The text says:
> Using an SPDX identifier as the license name is recommended.
But then doesn't use one in the example. I found this confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #240: Use an SPDX identifier in example, as recommended
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #240:
URL: https://github.com/apache/maven-site/pull/240#discussion_r662193689
##########
File path: content/apt/pom.apt
##########
@@ -1474,10 +1474,10 @@ Display parameters as parsed by Maven (in canonical form) and comparison result:
+-------------------------+
<licenses>
<license>
- <name>Apache License, Version 2.0</name>
+ <name>Apache-2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
- <comments>A business-friendly OSS license</comments>
+ <comments>Apache License, Version 2.0 - A business-friendly OSS license</comments>
Review comment:
typography nit: you want an em dash — after 2.0, not a hyphen
also probably make "A" lower case since it no longer starts the sentence and change "OSS" to "open source"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on pull request #240: Use an SPDX identifier in example, as recommended
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #240:
URL: https://github.com/apache/maven-site/pull/240#issuecomment-872241943
>
>
> @michael-o I think it would make sense to re-write the docs when a SPDX field is added, but right now, the docs say to put SPDX into the name, but then don't actually do it.
>
> Original SPDX suggesting PR for reference: #121
I agree with you, this is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on pull request #240: Use an SPDX identifier in example, as recommended
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #240:
URL: https://github.com/apache/maven-site/pull/240#issuecomment-872147844
I think this is wrong. the `name` shall remain as is. In a future version of the POM we will add something for SPDX. Therefore, I'd recommend to modify the SPDX part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] rjmunro commented on pull request #240: Use an SPDX identifier in example, as recommended
Posted by GitBox <gi...@apache.org>.
rjmunro commented on pull request #240:
URL: https://github.com/apache/maven-site/pull/240#issuecomment-872241122
@michael-o I think it would make sense to re-write the docs when a SPDX field is added, but right now, the docs say to put SPDX into the name, but then don't actually do it.
Original SPDX suggesting PR for reference: https://github.com/apache/maven-site/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org