You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/06/10 03:02:06 UTC

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23001


Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................

WIP KUDU-1261 support 1D-arrays in TypeInfo

This changelist adds rudimentary support for one-dimensional arrays
of scalar types into TypeInfo.  Essentially, the run-time registry
of data types is now populated with necessary TypeInfo objects.
It also adds basic tests scenarios to verify the contents of the
TypeInfo registry once the necessary array types have been added.

WIP:
  * collect feedback on NestedTypeDescriptor in TypeInfo
  * implement
     ** ArrayTypeTraits::Compare()
     ** ArrayTypeTraits::AreConsecutive()
     ** ArrayTypeTraits::AppendDebugStringForValue()
  * add more tests?

Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
---
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
3 files changed, 370 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/23001/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] KUDU-1261 support 1D arrays in TypeInfo

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: KUDU-1261 support 1D arrays in TypeInfo
......................................................................

KUDU-1261 support 1D arrays in TypeInfo

This changelist updates TypeInfo to support one-dimensional arrays
of Kudu scalar types.  With this patch, the run-time registry of data
types is now populated with necessary TypeInfo objects for 1D arrays
for every registered Kudu scalar data type.

This changelist also adds basic tests scenarios to verify the contents
of the TypeInfo registry once the necessary array types have been added.

The following methods aren't implemented yet as a part of this changelist
and will be implemented in a follow-up changelist after the introduction
of the ArrayCellMetadataView class on top of [1]:
  * ArrayTypeTraits::Compare()
  * ArrayTypeTraits::AreConsecutive()
  * ArrayTypeTraits::AppendDebugStringForValue()

[1] https://gerrit.cloudera.org/#/c/23002/

Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Reviewed-on: http://gerrit.cloudera.org:8080/23001
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
3 files changed, 376 insertions(+), 13 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 support 1D arrays in TypeInfo

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-1261 support 1D arrays in TypeInfo
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 5: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1727/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 30 Aug 2025 05:24:40 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1550/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jul 2025 05:35:04 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 support 1D arrays in TypeInfo

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23001

to look at the new patch set (#7).

Change subject: KUDU-1261 support 1D arrays in TypeInfo
......................................................................

KUDU-1261 support 1D arrays in TypeInfo

This changelist updates TypeInfo to support one-dimensional arrays
of Kudu scalar types.  With this patch, the run-time registry of data
types is now populated with necessary TypeInfo objects for 1D arrays
for every registered Kudu scalar data type.

This changelist also adds basic tests scenarios to verify the contents
of the TypeInfo registry once the necessary array types have been added.

The following methods aren't implemented yet as a part of this changelist
and will be implemented in a follow-up changelist after the introduction
of the ArrayCellMetadataView class on top of [1]:
  * ArrayTypeTraits::Compare()
  * ArrayTypeTraits::AreConsecutive()
  * ArrayTypeTraits::AppendDebugStringForValue()

[1] https://gerrit.cloudera.org/#/c/23002/

Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
---
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
3 files changed, 376 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/23001/7
-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1620/


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 28 Jul 2025 19:37:42 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1727/


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 30 Aug 2025 05:13:19 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 4: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1620/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 28 Jul 2025 19:49:23 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1432/


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 03:02:10 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 support 1D arrays in TypeInfo

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: KUDU-1261 support 1D arrays in TypeInfo
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Sep 2025 00:39:21 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1432/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 03:15:59 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23001

to look at the new patch set (#6).

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................

WIP KUDU-1261 support 1D-arrays in TypeInfo

This changelist adds rudimentary support for one-dimensional arrays
of scalar types into TypeInfo.  Essentially, the run-time registry
of data types is now populated with necessary TypeInfo objects.
It also adds basic tests scenarios to verify the contents of the
TypeInfo registry once the necessary array types have been added.

WIP:
  * implement
     ** ArrayTypeTraits::Compare()
     ** ArrayTypeTraits::AreConsecutive()
     ** ArrayTypeTraits::AppendDebugStringForValue()
  * add more tests?

Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
---
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
3 files changed, 379 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/23001/6
-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23001/2/src/kudu/common/types.h
File src/kudu/common/types.h:

http://gerrit.cloudera.org:8080/#/c/23001/2/src/kudu/common/types.h@57
PS2, Line 57: one-dimensional
Do we want to leave some wriggle room for future work on multi-dimensional array type support?



-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Jun 2025 05:25:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23001/2/src/kudu/common/types.h
File src/kudu/common/types.h:

http://gerrit.cloudera.org:8080/#/c/23001/2/src/kudu/common/types.h@57
PS2, Line 57: one-dimensional
> Do we want to leave some wriggle room for future work on multi-dimensional 
Right, that's hinted at in 'TODO' at lines 59-60.  Since type registry is an implementation detail, and we don't export anything from types.h or install the file for C++ client library, we can do so anytime in future.

As of now, I don't see anything beyond these two methods that is necessary for data type resolution in the scope of array data type project.  Also, if going beyond 1D scalar arrays right now, it would require re-designing the type registry, but I'm not sure I understand all the requirements for the type registry if supporting multi-dimensional arrays at the time of writing.



-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Jun 2025 06:24:01 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 6:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1734/


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 16:09:40 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23001

to look at the new patch set (#4).

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................

WIP KUDU-1261 support 1D-arrays in TypeInfo

This changelist adds rudimentary support for one-dimensional arrays
of scalar types into TypeInfo.  Essentially, the run-time registry
of data types is now populated with necessary TypeInfo objects.
It also adds basic tests scenarios to verify the contents of the
TypeInfo registry once the necessary array types have been added.

WIP:
  * collect feedback on NestedTypeDescriptor in TypeInfo
  * implement
     ** ArrayTypeTraits::Compare()
     ** ArrayTypeTraits::AreConsecutive()
     ** ArrayTypeTraits::AppendDebugStringForValue()
  * add more tests?

Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
---
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
3 files changed, 370 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/23001/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1437/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 08:14:44 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 support 1D arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: KUDU-1261 support 1D arrays in TypeInfo
......................................................................


Patch Set 7: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1756/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 04 Sep 2025 00:31:20 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 support 1D arrays in TypeInfo

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: KUDU-1261 support 1D arrays in TypeInfo
......................................................................


Patch Set 7: Verified+1

unrelated test failures of known flaky java tests; also KUDU-3660 in TSAN build


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Sep 2025 01:10:15 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 6: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1734/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 16:26:00 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 support 1D arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: KUDU-1261 support 1D arrays in TypeInfo
......................................................................


Patch Set 7:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1756/


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 23:07:23 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1437/


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 06:49:16 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 2: Verified+1

unrelated Java test failures (TSAN): org.apache.kudu.client.TestKuduClient


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 16:56:44 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 support 1D-arrays in TypeInfo

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )

Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1550/


-- 
To view, visit http://gerrit.cloudera.org:8080/23001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60
Gerrit-Change-Number: 23001
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jul 2025 05:19:36 +0000
Gerrit-HasComments: No