You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by egor duda <de...@logos-m.ru> on 2002/10/16 13:25:47 UTC
[PATCH] Installing on cygwin -- add .exe extension when needed
Hi!
This patch should fix the problem with .exe extension during
'make install' on cygwin, which Noel Yap has reported recently. It
should be portable among autoconf-based platforms. I'm not sure if
MSVC build is affected, though.
Index: ./Makefile.in
===================================================================
--- ./Makefile.in
+++ ./Makefile.in Wed Oct 16 17:08:50 2002
@@ -73,6 +73,8 @@
LINK = $(LIBTOOL) $(LTFLAGS) --mode=link $(LT_LDFLAGS) $(CC) $(CFLAGS) $(LDFLAGS) -rpath $(libdir)
LINK_APACHE_MOD = $(LIBTOOL) $(LTFLAGS) --mode=link $(LT_LDFLAGS) $(CC) $(CFLAGS) $(LDFLAGS) -rpath $(APACHE_LIBEXECDIR)
+EXEEXT = @EXEEXT@
+
INSTALL = @INSTALL@
INSTALL_LIB = $(LIBTOOL) --mode=install $(INSTALL)
INSTALL_BASE_LIB = $(INSTALL_LIB)
Index: ./configure.in
===================================================================
--- ./configure.in
+++ ./configure.in Mon Oct 14 12:28:20 2002
@@ -75,6 +75,8 @@
AC_SUBST(SVN_EXTRA_LIBS)
AC_SUBST(SVN_SUBDIRS)
+AC_EXEEXT
+
dnl Configure APR, and local Berkeley DB if any --------------------------
Index: ./build/gen_make.py
===================================================================
--- ./build/gen_make.py
+++ ./build/gen_make.py Wed Oct 16 17:01:58 2002
@@ -13,7 +13,7 @@
class MakefileGenerator(gen_base.GeneratorBase):
_extension_map = {
- ('exe', 'target'): '',
+ ('exe', 'target'): '$(EXEEXT)',
('exe', 'object'): '.o',
('lib', 'target'): '.la',
('lib', 'object'): '.lo',
Egor. mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Installing on cygwin -- add .exe extension when needed
Posted by Branko Čibej <br...@xbc.nu>.
egor duda wrote:
>Hi!
>
>Wednesday, 16 October, 2002 you wrote:
>
>BC> egor duda wrote:
>
>
>
>>>Index: ./build/gen_make.py
>>>===================================================================
>>>--- ./build/gen_make.py
>>>+++ ./build/gen_make.py Wed Oct 16 17:01:58 2002
>>>@@ -13,7 +13,7 @@
>>>class MakefileGenerator(gen_base.GeneratorBase):
>>>
>>> _extension_map = {
>>>- ('exe', 'target'): '',
>>>+ ('exe', 'target'): '$(EXEEXT)',
>>> ('exe', 'object'): '.o',
>>> ('lib', 'target'): '.la',
>>> ('lib', 'object'): '.lo',
>>>
>>>
>>>
>>>
>BC> Uh, how do you expect this to work? Python doesn't expand environment
>BC> variables like that.
>
>Python is not supposed to expand this. It should just write it
>literally to the Makefile. The expansion is performed later by 'make'.
>
Ah, right. Sorry, I forgot this goes verbatim into the makefile.
>And yes, i actually did test it before posting :).
>
Good. :-)
>BTW, your mail client doesn't seem to honor 'Reply-To:' header. I
>intentionally set it to point to the list, yet the message was CC'ed
>to my personal address.
>
No, you didn't; the message I got from the mailing list didn't have a
reply-to. This one, which you sent directly to me, did. So I suspect
that the mailing list server on tigris.org is stripping reply-to headers.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Installing on cygwin -- add .exe extension when needed
Posted by egor duda <de...@logos-m.ru>.
Hi!
Wednesday, 16 October, 2002 you wrote:
BC> egor duda wrote:
>>Index: ./build/gen_make.py
>>===================================================================
>>--- ./build/gen_make.py
>>+++ ./build/gen_make.py Wed Oct 16 17:01:58 2002
>>@@ -13,7 +13,7 @@
>> class MakefileGenerator(gen_base.GeneratorBase):
>>
>> _extension_map = {
>>- ('exe', 'target'): '',
>>+ ('exe', 'target'): '$(EXEEXT)',
>> ('exe', 'object'): '.o',
>> ('lib', 'target'): '.la',
>> ('lib', 'object'): '.lo',
>>
>>
BC> Uh, how do you expect this to work? Python doesn't expand environment
BC> variables like that.
Python is not supposed to expand this. It should just write it
literally to the Makefile. The expansion is performed later by 'make'.
And yes, i actually did test it before posting :).
BTW, your mail client doesn't seem to honor 'Reply-To:' header. I
intentionally set it to point to the list, yet the message was CC'ed
to my personal address.
Egor. mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Installing on cygwin -- add .exe extension when needed
Posted by Daniel Rall <dl...@finemaltcoding.com>.
=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <br...@xbc.nu> writes:
> egor duda wrote:
>
> >Index: ./build/gen_make.py
> >===================================================================
> >--- ./build/gen_make.py
> >+++ ./build/gen_make.py Wed Oct 16 17:01:58 2002
> >@@ -13,7 +13,7 @@
> > class MakefileGenerator(gen_base.GeneratorBase):
> > _extension_map = {
>
> >- ('exe', 'target'): '',
> >+ ('exe', 'target'): '$(EXEEXT)',
> > ('exe', 'object'): '.o',
> > ('lib', 'target'): '.la',
> > ('lib', 'object'): '.lo',
> >
>
> Uh, how do you expect this to work? Python doesn't expand environment
> variables like that.
Something like this would work assuming EXEEXT really is an env var (I
haven't been paying enough attention to know one way or another):
>>> import os
>>> os.environ.get('EXEEXT', 'exe')
'exe'
This is probably pretty obvious to anyone who knows Python, but I'm
still learning it. :)
--
Daniel Rall <dl...@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Installing on cygwin -- add .exe extension when needed
Posted by Branko Čibej <br...@xbc.nu>.
egor duda wrote:
>Index: ./build/gen_make.py
>===================================================================
>--- ./build/gen_make.py
>+++ ./build/gen_make.py Wed Oct 16 17:01:58 2002
>@@ -13,7 +13,7 @@
> class MakefileGenerator(gen_base.GeneratorBase):
>
> _extension_map = {
>- ('exe', 'target'): '',
>+ ('exe', 'target'): '$(EXEEXT)',
> ('exe', 'object'): '.o',
> ('lib', 'target'): '.la',
> ('lib', 'object'): '.lo',
>
>
Uh, how do you expect this to work? Python doesn't expand environment
variables like that.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org