You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/01 11:40:03 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #5946: arch/xtensa: Add xtensa_tcbinfo struct that contains helpful offsets.
Ouss4 opened a new pull request #5946:
URL: https://github.com/apache/incubator-nuttx/pull/5946
## Summary
Add Xtensa's version of tcbinfo.
## Impact
None.
## Testing
A WIP on OpenOCD, this version only needs the first offset for registers, so I didn't pay too much attention to what follows, especially those that are under a configuration option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5946: arch/xtensa: Add xtensa_tcbinfo struct that contains helpful offsets.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #5946:
URL: https://github.com/apache/incubator-nuttx/pull/5946#discussion_r840638793
##########
File path: arch/xtensa/src/esp32/Make.defs
##########
@@ -41,6 +41,11 @@ CMN_CSRCS += xtensa_reprioritizertr.c xtensa_schedsigaction.c
CMN_CSRCS += xtensa_sigdeliver.c xtensa_stackframe.c xtensa_udelay.c
CMN_CSRCS += xtensa_unblocktask.c xtensa_usestack.c xtensa_swint.c xtensa_switchcontext.c
+
+ifeq ($(CONFIG_DEBUG_TCBINFO),y)
+CMN_CSRCS += xtensa_tcbinfo.c
+endif
+
# Configuration-dependent common XTENSA files
Review comment:
```suggestion
# Configuration-dependent common XTENSA files
ifeq ($(CONFIG_DEBUG_TCBINFO),y)
CMN_CSRCS += xtensa_tcbinfo.c
endif
```
It should be placed below the comment for `Configuration-dependent common XTENSA files`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5946: arch/xtensa: Add xtensa_tcbinfo struct that contains helpful offsets.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #5946:
URL: https://github.com/apache/incubator-nuttx/pull/5946#discussion_r840637202
##########
File path: arch/xtensa/src/esp32/Make.defs
##########
@@ -41,6 +41,11 @@ CMN_CSRCS += xtensa_reprioritizertr.c xtensa_schedsigaction.c
CMN_CSRCS += xtensa_sigdeliver.c xtensa_stackframe.c xtensa_udelay.c
CMN_CSRCS += xtensa_unblocktask.c xtensa_usestack.c xtensa_swint.c xtensa_switchcontext.c
+
Review comment:
```suggestion
```
nit: There are two empty lines here, one may be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5946: arch/xtensa: Add xtensa_tcbinfo struct that contains helpful offsets.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5946:
URL: https://github.com/apache/incubator-nuttx/pull/5946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #5946: arch/xtensa: Add xtensa_tcbinfo struct that contains helpful offsets.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #5946:
URL: https://github.com/apache/incubator-nuttx/pull/5946#discussion_r840719469
##########
File path: arch/xtensa/src/esp32/Make.defs
##########
@@ -41,6 +41,11 @@ CMN_CSRCS += xtensa_reprioritizertr.c xtensa_schedsigaction.c
CMN_CSRCS += xtensa_sigdeliver.c xtensa_stackframe.c xtensa_udelay.c
CMN_CSRCS += xtensa_unblocktask.c xtensa_usestack.c xtensa_swint.c xtensa_switchcontext.c
+
Review comment:
Fixed, thanks.
##########
File path: arch/xtensa/src/esp32/Make.defs
##########
@@ -41,6 +41,11 @@ CMN_CSRCS += xtensa_reprioritizertr.c xtensa_schedsigaction.c
CMN_CSRCS += xtensa_sigdeliver.c xtensa_stackframe.c xtensa_udelay.c
CMN_CSRCS += xtensa_unblocktask.c xtensa_usestack.c xtensa_swint.c xtensa_switchcontext.c
+
+ifeq ($(CONFIG_DEBUG_TCBINFO),y)
+CMN_CSRCS += xtensa_tcbinfo.c
+endif
+
# Configuration-dependent common XTENSA files
Review comment:
Fixed, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org