You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by codecov on 2023/01/26 14:39:01 UTC
[GitHub] [superset] codecov[bot] commented on pull request #22871: chore(db_engine_specs): clean up column spec logic and add tests
codecov[bot] commented on PR #22871:
URL: https://github.com/apache/superset/pull/22871#issuecomment-1405104105
# [Codecov](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22871](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1112b07) into [master](https://codecov.io/gh/apache/superset/commit/f8edcd7ae2f1a716505327770b5abaa7691c784a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8edcd7) will **decrease** coverage by `11.02%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 1112b07 differs from pull request most recent head 1e07195. Consider uploading reports for the commit 1e07195 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22871 +/- ##
===========================================
- Coverage 67.21% 56.20% -11.02%
===========================================
Files 1879 1879
Lines 72093 72096 +3
Branches 7897 7897
===========================================
- Hits 48459 40521 -7938
- Misses 21606 29547 +7941
Partials 2028 2028
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.49% <30.11%> (-0.04%)` | :arrow_down: |
| python | `58.75% <100.00%> (-22.98%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.42% <100.00%> (+0.77%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `79.03% <ø> (-5.30%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `64.95% <ø> (-25.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `93.54% <100.00%> (+3.54%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `75.65% <100.00%> (-14.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `51.98% <100.00%> (-17.74%)` | :arrow_down: |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `69.09% <100.00%> (+2.42%)` | :arrow_up: |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `96.42% <100.00%> (+4.12%)` | :arrow_up: |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `95.23% <100.00%> (+5.23%)` | :arrow_up: |
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | `88.09% <100.00%> (+2.72%)` | :arrow_up: |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `82.53% <100.00%> (-0.80%)` | :arrow_down: |
| ... and [326 more](https://codecov.io/gh/apache/superset/pull/22871?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org