You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/05 19:06:35 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request #3155: Switch typescript and cpplite editors to multiviews
matthiasblaesing opened a new pull request #3155:
URL: https://github.com/apache/netbeans/pull/3155
I noticed that the "History" tab was missing for typescript editor. At times I use it to access the history
of a single file. I think it is appropriate to use MultiViews for the typescript editor. As the typescript
and cpplite editors are from the same heritage, I adjusted them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3155: Switch typescript and cpplite editors to multiviews
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3155:
URL: https://github.com/apache/netbeans/pull/3155#discussion_r702936864
##########
File path: cpplite/cpplite.editor/src/org/netbeans/modules/cpplite/editor/file/CDataObject.java
##########
@@ -112,14 +116,27 @@
@GrammarRegistration(grammar="resources/c.tmLanguage.json", mimeType=MIMETypes.C)
public class CDataObject extends MultiDataObject {
+ static final String ICON = "org/netbeans/modules/cpplite/editor/file/resources/CSrcIcon.gif";
Review comment:
Maybe, we can add `@StaticResource`.
Other files as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3155: Switch typescript and cpplite editors to multiviews
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3155:
URL: https://github.com/apache/netbeans/pull/3155#issuecomment-919528409
Screenshot after:
The highlighted area is the result of adding multiviews. The editor is the the base view, that was present before, while the history tab get added by this changeset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3155: Switch typescript and cpplite editors to multiviews
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3155:
URL: https://github.com/apache/netbeans/pull/3155#issuecomment-918425760
If noone objects, I'll merge this by the end of the week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #3155: Switch typescript and cpplite editors to multiviews
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #3155:
URL: https://github.com/apache/netbeans/pull/3155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3155: Switch typescript and cpplite editors to multiviews
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3155:
URL: https://github.com/apache/netbeans/pull/3155#discussion_r703046230
##########
File path: cpplite/cpplite.editor/src/org/netbeans/modules/cpplite/editor/file/CDataObject.java
##########
@@ -112,14 +116,27 @@
@GrammarRegistration(grammar="resources/c.tmLanguage.json", mimeType=MIMETypes.C)
public class CDataObject extends MultiDataObject {
+ static final String ICON = "org/netbeans/modules/cpplite/editor/file/resources/CSrcIcon.gif";
Review comment:
Valid point - updated this accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3155: Switch typescript and cpplite editors to multiviews
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3155:
URL: https://github.com/apache/netbeans/pull/3155#issuecomment-919534257
Perfect! Thank you for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists