You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/02 11:22:05 UTC
[GitHub] [spark] yma11 commented on a change in pull request #27546:
[SPARK-30773][ML]Support NativeBlas for level-1 routines
yma11 commented on a change in pull request #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#discussion_r386336068
##########
File path: mllib-local/pom.xml
##########
@@ -61,13 +61,17 @@
This spark-tags test-dep is needed even though it isn't used in this module, otherwise testing-cmds that exclude
them will yield errors.
-->
+ <dependency>
Review comment:
Without dependency of core, ConfigBuilder/ConfigEntry won't be accessible. So I'd propose to add an environment variable in spark-env.sh. see new commit for details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org