You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2008/10/01 23:37:44 UTC
[jira] Created: (QPID-1309) Build-time project name/version id for
non-autoconf builds
Build-time project name/version id for non-autoconf builds
----------------------------------------------------------
Key: QPID-1309
URL: https://issues.apache.org/jira/browse/QPID-1309
Project: Qpid
Issue Type: Improvement
Components: C++ Broker
Affects Versions: M4
Environment: Windows w/ Visual Studio
Reporter: Steve Huston
Priority: Minor
The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h with:
#include <string>
#ifdef HAVE_CONFIG_H
# include "config.h"
#endif
namespace qpid {
#ifdef HAVE_CONFIG_H
const std::string product = PACKAGE_NAME;
const std::string version = PACKAGE_VERSION;
const std::string saslName = SASL_BROKER_NAME;
#else
const std::string product = "qpidc";
const std::string version = "0.3";
const std::string saslName = "qpid-broker";
#endif
}
Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
Is this ok, or is there some more direct way to manage this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1309) Build-time project name/version id
for non-autoconf builds
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636700#action_12636700 ]
Ted Ross commented on QPID-1309:
--------------------------------
More detail...
The symbol BROKER_SASL_NAME is defined only when the configure script determines that SASL is supported. The new file (Version.h) added with this commit dereferences this symbol without checking if it is defined.
-Ted
> Build-time project name/version id for non-autoconf builds
> ----------------------------------------------------------
>
> Key: QPID-1309
> URL: https://issues.apache.org/jira/browse/QPID-1309
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: M4
> Environment: Windows w/ Visual Studio
> Reporter: Steve Huston
> Assignee: Steve Huston
> Priority: Minor
> Fix For: M4
>
> Attachments: vers.diff
>
>
> The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h that takes the applicable info from config.h when present and requires it to be set when no config.h is available (such as on Windows).
> Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
> Diffs are supplied.
> Is this ok, or is there some more direct way to manage this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1309) Build-time project name/version id for
non-autoconf builds
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston resolved QPID-1309.
--------------------------------
Resolution: Fixed
Sorry - thanks for the notice and explanation. A fixed Version.h was committed in svn revision 701535.
> Build-time project name/version id for non-autoconf builds
> ----------------------------------------------------------
>
> Key: QPID-1309
> URL: https://issues.apache.org/jira/browse/QPID-1309
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: M4
> Environment: Windows w/ Visual Studio
> Reporter: Steve Huston
> Assignee: Steve Huston
> Priority: Minor
> Fix For: M4
>
> Attachments: vers.diff
>
>
> The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h that takes the applicable info from config.h when present and requires it to be set when no config.h is available (such as on Windows).
> Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
> Diffs are supplied.
> Is this ok, or is there some more direct way to manage this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1309) Build-time project name/version id for
non-autoconf builds
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston updated QPID-1309:
-------------------------------
Attachment: vers.diff
I've attached diffs that represent changes made for this issue. I am going to commit these changes (revision 701227), but review is appreciated.
> Build-time project name/version id for non-autoconf builds
> ----------------------------------------------------------
>
> Key: QPID-1309
> URL: https://issues.apache.org/jira/browse/QPID-1309
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: M4
> Environment: Windows w/ Visual Studio
> Reporter: Steve Huston
> Priority: Minor
> Attachments: vers.diff
>
>
> The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h with:
> #include <string>
> #ifdef HAVE_CONFIG_H
> # include "config.h"
> #endif
> namespace qpid {
> #ifdef HAVE_CONFIG_H
> const std::string product = PACKAGE_NAME;
> const std::string version = PACKAGE_VERSION;
> const std::string saslName = SASL_BROKER_NAME;
> #else
> const std::string product = "qpidc";
> const std::string version = "0.3";
> const std::string saslName = "qpid-broker";
> #endif
> }
> Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
> Is this ok, or is there some more direct way to manage this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1309) Build-time project name/version id for
non-autoconf builds
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Ross reassigned QPID-1309:
------------------------------
Assignee: Steve Huston
> Build-time project name/version id for non-autoconf builds
> ----------------------------------------------------------
>
> Key: QPID-1309
> URL: https://issues.apache.org/jira/browse/QPID-1309
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: M4
> Environment: Windows w/ Visual Studio
> Reporter: Steve Huston
> Assignee: Steve Huston
> Priority: Minor
> Fix For: M4
>
> Attachments: vers.diff
>
>
> The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h that takes the applicable info from config.h when present and requires it to be set when no config.h is available (such as on Windows).
> Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
> Diffs are supplied.
> Is this ok, or is there some more direct way to manage this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1309) Build-time project name/version id for
non-autoconf builds
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston resolved QPID-1309.
--------------------------------
Resolution: Fixed
Fix Version/s: M4
> Build-time project name/version id for non-autoconf builds
> ----------------------------------------------------------
>
> Key: QPID-1309
> URL: https://issues.apache.org/jira/browse/QPID-1309
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: M4
> Environment: Windows w/ Visual Studio
> Reporter: Steve Huston
> Priority: Minor
> Fix For: M4
>
> Attachments: vers.diff
>
>
> The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h that takes the applicable info from config.h when present and requires it to be set when no config.h is available (such as on Windows).
> Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
> Diffs are supplied.
> Is this ok, or is there some more direct way to manage this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1309) Build-time project name/version id for
non-autoconf builds
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston updated QPID-1309:
-------------------------------
Description:
The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h that takes the applicable info from config.h when present and requires it to be set when no config.h is available (such as on Windows).
Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
Diffs are supplied.
Is this ok, or is there some more direct way to manage this?
was:
The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h with:
#include <string>
#ifdef HAVE_CONFIG_H
# include "config.h"
#endif
namespace qpid {
#ifdef HAVE_CONFIG_H
const std::string product = PACKAGE_NAME;
const std::string version = PACKAGE_VERSION;
const std::string saslName = SASL_BROKER_NAME;
#else
const std::string product = "qpidc";
const std::string version = "0.3";
const std::string saslName = "qpid-broker";
#endif
}
Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
Is this ok, or is there some more direct way to manage this?
> Build-time project name/version id for non-autoconf builds
> ----------------------------------------------------------
>
> Key: QPID-1309
> URL: https://issues.apache.org/jira/browse/QPID-1309
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: M4
> Environment: Windows w/ Visual Studio
> Reporter: Steve Huston
> Priority: Minor
> Attachments: vers.diff
>
>
> The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h that takes the applicable info from config.h when present and requires it to be set when no config.h is available (such as on Windows).
> Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
> Diffs are supplied.
> Is this ok, or is there some more direct way to manage this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (QPID-1309) Build-time project name/version id for
non-autoconf builds
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Ross reopened QPID-1309:
----------------------------
The commits associated with this issue break the build when the --without-sasl configuration option is supplied, or when configure is run on a system without SASL support.
-Ted
> Build-time project name/version id for non-autoconf builds
> ----------------------------------------------------------
>
> Key: QPID-1309
> URL: https://issues.apache.org/jira/browse/QPID-1309
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: M4
> Environment: Windows w/ Visual Studio
> Reporter: Steve Huston
> Priority: Minor
> Fix For: M4
>
> Attachments: vers.diff
>
>
> The qpid product name and version number are currently picked up from PACKAGE_NAME, PACKAGE_VERSION via configure.ac. This mechanism doesn't exist in Windows Visual Studio. The alternative I'm proposing is to create a new file qpid/cpp/src/qpid/Version.h that takes the applicable info from config.h when present and requires it to be set when no config.h is available (such as on Windows).
> Applicable code changes are to refer to qpid::product, etc. rather than PACKAGE_NAME, etc. This requires a comment in configure.ac noting that if the name/version changes, also change it in Version.h
> Diffs are supplied.
> Is this ok, or is there some more direct way to manage this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.