[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2942: Add optional page row count limit for parquet `WriterProperties` (#2941)

[GitBox <gi...@apache.org>]

Ted-Jiang commented on code in PR #2942:
URL: https://github.com/apache/arrow-rs/pull/2942#discussion_r1013838557


##########
parquet/src/column/writer/mod.rs:
##########
@@ -569,11 +569,13 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
         //
         // In such a scenario the dictionary decoder may return an estimated encoded
         // size in excess of the page size limit, even when there are no buffered values
-        if self.encoder.num_values() == 0 {
+        if self.page_metrics.num_buffered_values == 0 {

Review Comment:
   I think this fix the `should_add_data_page` bug



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org