[GitHub] [fineract] vidakovic commented on a change in pull request #2154: FINERACT-849: Minor fixes + docs for EclipseLink/PostgreSQL support

[GitBox <gi...@apache.org>]

vidakovic commented on a change in pull request #2154:
URL: https://github.com/apache/fineract/pull/2154#discussion_r828044125



##########
File path: fineract-doc/build.gradle
##########
@@ -44,14 +44,11 @@ asciidoctorj {
     version = '2.4.0'
 
     attributes = [
-        revnumber: {
-            project.version.toString()
-        },
         generated: "${buildDir}/generated/asciidoc",
         imagesdir: 'images',
         diagrams: 'diagrams',
-        years: '2015-2020',
-        revnumber: "$version".toString(),
+        years: '2015-2022',
+        revnumber: '1.7.0',

Review comment:
       hmmm... that way you always have to remember to set this version thing when you do a release... versioning is now handled by a Gradle plugin (in between releases you'll see Git hashes that clearly indicate against which commit this doc was created)... any specific reason why this should be fixed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org