You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/12/01 04:47:38 UTC

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #4990: [Doris On ES][Bug-fix] fix boolean predicate pushdown manner

wuyunfeng opened a new pull request #4990:
URL: https://github.com/apache/incubator-doris/pull/4990


   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [] Bugfix (non-breaking change which fixes an issue)
   - [] New feature (non-breaking change which adds functionality)
   - [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [] Documentation Update (if none of the other choices apply)
   - [] Code refactor (Modify the code structure, format the code, etc...)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
   - [] Compiling and unit tests pass locally with my changes
   - [] I have added tests that prove my fix is effective or that my feature works
   - [] If this change need a document change, I have updated the document
   - [] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] wuyunfeng merged pull request #4990: [Doris On ES][Bug-fix] fix boolean predicate pushdown manner

Posted by GitBox <gi...@apache.org>.
wuyunfeng merged pull request #4990:
URL: https://github.com/apache/incubator-doris/pull/4990


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #4990: [Doris On ES][Bug-fix] fix boolean predicate pushdown manner

Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #4990:
URL: https://github.com/apache/incubator-doris/pull/4990#discussion_r533153262



##########
File path: be/src/exec/es/es_query_builder.cpp
##########
@@ -50,19 +50,39 @@ void ESQueryBuilder::to_json(rapidjson::Document* document, rapidjson::Value* qu
 }
 
 TermQueryBuilder::TermQueryBuilder(const std::string& field, const std::string& term)
-        : _field(field), _term(term) {}
+        : _field(field), _term(term), _match_none(false) {}
 
 TermQueryBuilder::TermQueryBuilder(const ExtBinaryPredicate& binary_predicate)
-        : _field(binary_predicate.col.name), _term(binary_predicate.value.to_string()) {}
+        : _field(binary_predicate.col.name), _match_none(false) {
+        if (binary_predicate.col.type.type == PrimitiveType::TYPE_BOOLEAN) {
+            int val = atoi(binary_predicate.value.to_string().c_str());

Review comment:
       use StringParse::string_to_int instead




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4990: [Doris On ES][Bug-fix] fix boolean predicate pushdown manner

Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on a change in pull request #4990:
URL: https://github.com/apache/incubator-doris/pull/4990#discussion_r533312497



##########
File path: be/src/exec/es/es_query_builder.cpp
##########
@@ -50,19 +50,39 @@ void ESQueryBuilder::to_json(rapidjson::Document* document, rapidjson::Value* qu
 }
 
 TermQueryBuilder::TermQueryBuilder(const std::string& field, const std::string& term)
-        : _field(field), _term(term) {}
+        : _field(field), _term(term), _match_none(false) {}
 
 TermQueryBuilder::TermQueryBuilder(const ExtBinaryPredicate& binary_predicate)
-        : _field(binary_predicate.col.name), _term(binary_predicate.value.to_string()) {}
+        : _field(binary_predicate.col.name), _match_none(false) {
+        if (binary_predicate.col.type.type == PrimitiveType::TYPE_BOOLEAN) {
+            int val = atoi(binary_predicate.value.to_string().c_str());

Review comment:
       I think this is ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] imay commented on a change in pull request #4990: [Doris On ES][Bug-fix] fix boolean predicate pushdown manner

Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #4990:
URL: https://github.com/apache/incubator-doris/pull/4990#discussion_r533073600



##########
File path: be/src/exec/es/es_query_builder.cpp
##########
@@ -53,16 +53,37 @@ TermQueryBuilder::TermQueryBuilder(const std::string& field, const std::string&
         : _field(field), _term(term) {}
 
 TermQueryBuilder::TermQueryBuilder(const ExtBinaryPredicate& binary_predicate)
-        : _field(binary_predicate.col.name), _term(binary_predicate.value.to_string()) {}
+        : _field(binary_predicate.col.name) {
+        _match_none_ = false;
+        if (binary_predicate.col.type.type == PrimitiveType::TYPE_BOOLEAN) {
+            int val = atoi(binary_predicate.value.to_string().c_str());
+            if (val == 1) {
+                _term = std::string("true");
+            } else if (val == 0){
+                _term = std::string("false");
+            } else {
+                // keep semantic consistent with mysql
+                _match_none_ = true;
+            }
+        } else {
+            _term = std::move(binary_predicate.value.to_string());

Review comment:
       std::move is useless

##########
File path: be/src/exec/es/es_query_builder.h
##########
@@ -53,6 +53,7 @@ class TermQueryBuilder : public QueryBuilder {
 private:
     std::string _field;
     std::string _term;
+    bool _match_none_;

Review comment:
       1. _match_none Is preferred.
   2. _match_none is not initialized before use.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org