You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/11/07 01:28:44 UTC
[GitHub] [fineract] vorburger opened a new pull request #1497: Enable JavaTimeDefaultTimeZone rule in ErrorProne (FINERACT-1112)
vorburger opened a new pull request #1497:
URL: https://github.com/apache/fineract/pull/1497
Let's enable https://errorprone.info/bugpattern/JavaTimeDefaultTimeZone given @percyashu work in FINERACT-1112.
There are probably a lot more https://errorprone.info/bugpatterns we could enable now (time related, perhaps even others)... interested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on pull request #1497: Enable JavaTimeDefaultTimeZone rule in ErrorProne (FINERACT-1112)
Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #1497:
URL: https://github.com/apache/fineract/pull/1497#issuecomment-723388693
LGTM! Concerning enabling more bugpatterns I totally agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu merged pull request #1497: Enable JavaTimeDefaultTimeZone rule in ErrorProne (FINERACT-1112)
Posted by GitBox <gi...@apache.org>.
percyashu merged pull request #1497:
URL: https://github.com/apache/fineract/pull/1497
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on pull request #1497: Enable JavaTimeDefaultTimeZone rule in ErrorProne (FINERACT-1112)
Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #1497:
URL: https://github.com/apache/fineract/pull/1497#issuecomment-724605500
@vorburger Thanks and it is clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1497: Enable JavaTimeDefaultTimeZone rule in ErrorProne (FINERACT-1112)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1497:
URL: https://github.com/apache/fineract/pull/1497#issuecomment-723540457
@percyashu thanks for merging this! Minor feedback: Use Merge with Rebase instead of Merge Commit next time, see https://github.com/apache/fineract#merge-strategy. OK for you? Just ask if not clear!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org