[GitHub] [beam] rbrtwng commented on pull request #25236: SpannerIO: parameterizing partitionQuery timeout

["rbrtwng (via GitHub)" <gi...@apache.org>]

rbrtwng commented on PR #25236:
URL: https://github.com/apache/beam/pull/25236#issuecomment-1421402684

   Thanks @nielm for the review. @darshan-sj and I have sync'ed and believed that not having a default deadline in SpannerIO makes most sense for now. That's, unless the user explicitly supplies a timeout, the default value from client library should be honored.  Here's the rationale: 
   
   - Though setting a default to a sensible larger value in SpannerConfig will make it "just work", it might also hide some potential issues. 
   -  We discussed with a few other engineers in Spanner team and generally we believe the current default deadline of 30s is too small - but PartitionQuery is mainly used in batch workload so it actually makes more sense to bump up the default deadline from the client library side, not from SpannerIO.  I will follow up separately on that. 
   
   In short, I would support the current fix plan and give users the flexibility to "fix it" when they start seeing deadline exceeded errors. 
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org