You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2012/04/24 14:57:34 UTC

[jira] [Created] (DERBY-5711) NullsTest doesn't call super.tearDown()

Knut Anders Hatlen created DERBY-5711:
-----------------------------------------

             Summary: NullsTest doesn't call super.tearDown()
                 Key: DERBY-5711
                 URL: https://issues.apache.org/jira/browse/DERBY-5711
             Project: Derby
          Issue Type: Bug
          Components: Test
    Affects Versions: 10.9.0.0
            Reporter: Knut Anders Hatlen
            Assignee: Knut Anders Hatlen


NullsTest has the following tearDown() method:

    public void tearDown() throws SQLException{
        getConnection().setAutoCommit(true);
    }

Since it doesn't call super.tearDown(), it doesn't release connections and statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (DERBY-5711) NullsTest doesn't call super.tearDown()

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-5711:
--------------------------------------

    Attachment: d5711-1a.diff

Since the current tearDown() method only calls setAutoCommit(), which is not neccessary since the connection is not going to be used anymore, I've removed the method in the attached patch. Then NullsTest will inherit BaseJDBCTestCase.tearDown() and do the right thing automatically.
                
> NullsTest doesn't call super.tearDown()
> ---------------------------------------
>
>                 Key: DERBY-5711
>                 URL: https://issues.apache.org/jira/browse/DERBY-5711
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: d5711-1a.diff
>
>
> NullsTest has the following tearDown() method:
>     public void tearDown() throws SQLException{
>         getConnection().setAutoCommit(true);
>     }
> Since it doesn't call super.tearDown(), it doesn't release connections and statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (DERBY-5711) NullsTest doesn't call super.tearDown()

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260521#comment-13260521 ] 

Kristian Waagan commented on DERBY-5711:
----------------------------------------

Sounds like the right thing to do, +1.
                
> NullsTest doesn't call super.tearDown()
> ---------------------------------------
>
>                 Key: DERBY-5711
>                 URL: https://issues.apache.org/jira/browse/DERBY-5711
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: d5711-1a.diff
>
>
> NullsTest has the following tearDown() method:
>     public void tearDown() throws SQLException{
>         getConnection().setAutoCommit(true);
>     }
> Since it doesn't call super.tearDown(), it doesn't release connections and statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (DERBY-5711) NullsTest doesn't call super.tearDown()

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen closed DERBY-5711.
-------------------------------------

          Resolution: Fixed
       Fix Version/s: 10.9.0.0
    Issue & fix info:   (was: Patch Available)

Thanks, Kristian.
Committed revision 1330120.
                
> NullsTest doesn't call super.tearDown()
> ---------------------------------------
>
>                 Key: DERBY-5711
>                 URL: https://issues.apache.org/jira/browse/DERBY-5711
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>             Fix For: 10.9.0.0
>
>         Attachments: d5711-1a.diff
>
>
> NullsTest has the following tearDown() method:
>     public void tearDown() throws SQLException{
>         getConnection().setAutoCommit(true);
>     }
> Since it doesn't call super.tearDown(), it doesn't release connections and statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira