You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "wypoon (via GitHub)" <gi...@apache.org> on 2023/05/31 00:16:53 UTC

[GitHub] [iceberg] wypoon commented on issue #7612: DataFile creation by file path seems wrong

wypoon commented on issue #7612:
URL: https://github.com/apache/iceberg/issues/7612#issuecomment-1569311184

   @gaborkaszab there is indeed a problem with `TableMigrationUtil.listPartition` because it uses `DataFiles.Builder#withPartitionPath`. However, the problem is not with the partition URI being URL encoded. That is fine. The problem is with `TableMigrationUtil.listPartition` building a partition key of the form `a=1/b=2` and then `DataFiles.fillFromPath` taking this String and trying to recover the partition values by splitting it along the character '/'.
   In `DataFiles.Builder` we have the partition URI, which is correct; we just need to get all the partition values so we can set them in the `DataFile` we're building. `withPartitionPath` is not able to do it.
   I have a fix for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org