You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/10/27 06:21:29 UTC

[GitHub] [incubator-brpc] darionyaphet opened a new pull request #1279: Small alignment in examples

darionyaphet opened a new pull request #1279:
URL: https://github.com/apache/incubator-brpc/pull/1279


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] darionyaphet commented on a change in pull request #1279: Small alignment in examples

Posted by GitBox <gi...@apache.org>.
darionyaphet commented on a change in pull request #1279:
URL: https://github.com/apache/incubator-brpc/pull/1279#discussion_r512585967



##########
File path: example/echo_c++/client.cpp
##########
@@ -76,10 +76,10 @@ int main(int argc, char* argv[]) {
         stub.Echo(&cntl, &request, &response, NULL);
         if (!cntl.Failed()) {
             LOG(INFO) << "Received response from " << cntl.remote_side()
-                << " to " << cntl.local_side()

Review comment:
       yep There is no other meaning.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] gydong commented on a change in pull request #1279: Small alignment in examples

Posted by GitBox <gi...@apache.org>.
gydong commented on a change in pull request #1279:
URL: https://github.com/apache/incubator-brpc/pull/1279#discussion_r513131903



##########
File path: example/echo_c++/client.cpp
##########
@@ -76,10 +76,10 @@ int main(int argc, char* argv[]) {
         stub.Echo(&cntl, &request, &response, NULL);
         if (!cntl.Failed()) {
             LOG(INFO) << "Received response from " << cntl.remote_side()
-                << " to " << cntl.local_side()

Review comment:
       I mean it seems here the coding style was the same with other files. Why not just keeping what it was




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] darionyaphet closed pull request #1279: Small alignment in examples

Posted by GitBox <gi...@apache.org>.
darionyaphet closed pull request #1279:
URL: https://github.com/apache/incubator-brpc/pull/1279


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] gydong commented on a change in pull request #1279: Small alignment in examples

Posted by GitBox <gi...@apache.org>.
gydong commented on a change in pull request #1279:
URL: https://github.com/apache/incubator-brpc/pull/1279#discussion_r512503923



##########
File path: example/echo_c++/client.cpp
##########
@@ -76,10 +76,10 @@ int main(int argc, char* argv[]) {
         stub.Echo(&cntl, &request, &response, NULL);
         if (!cntl.Failed()) {
             LOG(INFO) << "Received response from " << cntl.remote_side()
-                << " to " << cntl.local_side()

Review comment:
       Just keep the same indent style as that in other soruce code files?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org