You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Brock Noland <br...@cloudera.com> on 2014/01/16 23:42:24 UTC

Review Request 16994: SENTRY-90 Normalize scratch path for comparison

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16994/
-----------------------------------------------------------

Review request for sentry and Shreepadma Venugopalan.


Bugs: SENTRY-90
    https://issues.apache.org/jira/browse/SENTRY-90


Repository: sentry


Description
-------

Re-factors the path implication code to a common location so it can be used in both the binding layer and in the policy file layer.


Diffs
-----

  pom.xml 7fd7696 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 0dd28b7 
  sentry-core/sentry-core-common/pom.xml 9b7d067 
  sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java PRE-CREATION 
  sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java PRE-CREATION 
  sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPermission.java e0eb2dc 
  sentry-provider/sentry-provider-file/pom.xml a804952 
  sentry-tests/sentry-tests-hive/.gitignore PRE-CREATION 

Diff: https://reviews.apache.org/r/16994/diff/


Testing
-------


Thanks,

Brock Noland


Re: Review Request 16994: SENTRY-90 Normalize scratch path for comparison

Posted by Brock Noland <br...@cloudera.com>.

> On Jan. 16, 2014, 11:26 p.m., Shreepadma Venugopalan wrote:
> > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java, line 36
> > <https://reviews.apache.org/r/16994/diff/1/?file=425114#file425114line36>
> >
> >     What if one has a schema and other doesn't? Hive's scratchdir for instance doesn't have scheme whereas the write entity that is captured as part of semantic analysis has scheme. This should probably be fixed in Hive but any way we can compensate for it?

Fixed in the version I will soon be uploading


> On Jan. 16, 2014, 11:26 p.m., Shreepadma Venugopalan wrote:
> > sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java, line 32
> > <https://reviews.apache.org/r/16994/diff/1/?file=425115#file425115line32>
> >
> >     Why would this comparison fail?

I added the following comment:

Privileges on /tmp/ are distinct from /tmp.+/ e.g. /tmp/ and /tmpdata/


- Brock


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16994/#review32094
-----------------------------------------------------------


On Jan. 16, 2014, 10:42 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16994/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 10:42 p.m.)
> 
> 
> Review request for sentry and Shreepadma Venugopalan.
> 
> 
> Bugs: SENTRY-90
>     https://issues.apache.org/jira/browse/SENTRY-90
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Re-factors the path implication code to a common location so it can be used in both the binding layer and in the policy file layer.
> 
> 
> Diffs
> -----
> 
>   pom.xml 7fd7696 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 0dd28b7 
>   sentry-core/sentry-core-common/pom.xml 9b7d067 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java PRE-CREATION 
>   sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java PRE-CREATION 
>   sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPermission.java e0eb2dc 
>   sentry-provider/sentry-provider-file/pom.xml a804952 
>   sentry-tests/sentry-tests-hive/.gitignore PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Re: Review Request 16994: SENTRY-90 Normalize scratch path for comparison

Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16994/#review32094
-----------------------------------------------------------


Looks good mostly. Couple of comments.


sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java
<https://reviews.apache.org/r/16994/#comment60783>

    What if one has a schema and other doesn't? Hive's scratchdir for instance doesn't have scheme whereas the write entity that is captured as part of semantic analysis has scheme. This should probably be fixed in Hive but any way we can compensate for it?



sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java
<https://reviews.apache.org/r/16994/#comment60784>

    Why would this comparison fail?


- Shreepadma Venugopalan


On Jan. 16, 2014, 10:42 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16994/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 10:42 p.m.)
> 
> 
> Review request for sentry and Shreepadma Venugopalan.
> 
> 
> Bugs: SENTRY-90
>     https://issues.apache.org/jira/browse/SENTRY-90
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Re-factors the path implication code to a common location so it can be used in both the binding layer and in the policy file layer.
> 
> 
> Diffs
> -----
> 
>   pom.xml 7fd7696 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 0dd28b7 
>   sentry-core/sentry-core-common/pom.xml 9b7d067 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java PRE-CREATION 
>   sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java PRE-CREATION 
>   sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPermission.java e0eb2dc 
>   sentry-provider/sentry-provider-file/pom.xml a804952 
>   sentry-tests/sentry-tests-hive/.gitignore PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Re: Review Request 16994: SENTRY-90 Normalize scratch path for comparison

Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16994/#review32217
-----------------------------------------------------------

Ship it!


Ship It!

- Shreepadma Venugopalan


On Jan. 17, 2014, 8:21 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16994/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 8:21 p.m.)
> 
> 
> Review request for sentry and Shreepadma Venugopalan.
> 
> 
> Bugs: SENTRY-90
>     https://issues.apache.org/jira/browse/SENTRY-90
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Re-factors the path implication code to a common location so it can be used in both the binding layer and in the policy file layer.
> 
> 
> Diffs
> -----
> 
>   pom.xml 7fd7696 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 0dd28b7 
>   sentry-core/sentry-core-common/pom.xml 9b7d067 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java PRE-CREATION 
>   sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java PRE-CREATION 
>   sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPermission.java e0eb2dc 
>   sentry-provider/sentry-provider-file/pom.xml a804952 
>   sentry-tests/sentry-tests-hive/.gitignore PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Re: Review Request 16994: SENTRY-90 Normalize scratch path for comparison

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16994/
-----------------------------------------------------------

(Updated Jan. 17, 2014, 8:21 p.m.)


Review request for sentry and Shreepadma Venugopalan.


Changes
-------

Cleans up TestPathUtils


Bugs: SENTRY-90
    https://issues.apache.org/jira/browse/SENTRY-90


Repository: sentry


Description
-------

Re-factors the path implication code to a common location so it can be used in both the binding layer and in the policy file layer.


Diffs (updated)
-----

  pom.xml 7fd7696 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 0dd28b7 
  sentry-core/sentry-core-common/pom.xml 9b7d067 
  sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java PRE-CREATION 
  sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java PRE-CREATION 
  sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPermission.java e0eb2dc 
  sentry-provider/sentry-provider-file/pom.xml a804952 
  sentry-tests/sentry-tests-hive/.gitignore PRE-CREATION 

Diff: https://reviews.apache.org/r/16994/diff/


Testing
-------


Thanks,

Brock Noland


Re: Review Request 16994: SENTRY-90 Normalize scratch path for comparison

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16994/
-----------------------------------------------------------

(Updated Jan. 17, 2014, 4:11 p.m.)


Review request for sentry and Shreepadma Venugopalan.


Changes
-------

Updates based on review


Bugs: SENTRY-90
    https://issues.apache.org/jira/browse/SENTRY-90


Repository: sentry


Description
-------

Re-factors the path implication code to a common location so it can be used in both the binding layer and in the policy file layer.


Diffs (updated)
-----

  pom.xml 7fd7696 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 0dd28b7 
  sentry-core/sentry-core-common/pom.xml 9b7d067 
  sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java PRE-CREATION 
  sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java PRE-CREATION 
  sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPermission.java e0eb2dc 
  sentry-provider/sentry-provider-file/pom.xml a804952 
  sentry-tests/sentry-tests-hive/.gitignore PRE-CREATION 

Diff: https://reviews.apache.org/r/16994/diff/


Testing
-------


Thanks,

Brock Noland