You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Andrey Yegorov <an...@datastax.com> on 2022/05/04 15:53:12 UTC

Re: [VOTE] Release 4.15.0, release candidate #2

Hi everyone,

The vote has been out for 5 days - any feedback?

On Fri, Apr 29, 2022 at 2:08 PM Andrey Yegorov <an...@datastax.com>
wrote:

> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version 4.15.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "release-4.15.0-rc2" [4] with git
> sha f771b7664f7f83ae4ae3e8eaa516c879c4bc7897
>
> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1]
> https://github.com/apache/bookkeeper/pull/3155/files#diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af85a7964a2e57855
>
> [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.0-rc2/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1066/
> [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.0-rc2/
>
>
> --
> Andrey Yegorov
>


-- 
Andrey Yegorov

Re: [VOTE] Release 4.15.0, release candidate #2

Posted by Andrey Yegorov <an...@datastax.com>.
+1 (binding)

I built Pulsar with BK 4.15 RC,
CI ran the tests with RC1 (RC 2 in progress but it is not functionally
different): https://github.com/apache/pulsar/pull/15142

Performance regression is not confirmed:
https://github.com/apache/bookkeeper/issues/3258#issuecomment-1118033982 in
other environments.
I agree with Enrico we can do .1 release if there is a regression that
shows up in specific cases.


On Thu, May 5, 2022 at 8:04 AM Enrico Olivelli <eo...@gmail.com> wrote:

> +1 (binding)
>  verified checksums, signatures, RAT
> run all tests on Ubuntu JDK11
>
> Regarding the performance issues reported by Raul while it looks scary
> I don't find any performance regressions on the other projects that I
> follow other than Pravega (Pulsar, HerdDB...), so I am not sure we
> should hold the release.
>
> if we find the problem I pretty sure it won't be something about a API
> change or anything we can't fix in a 4.15.1 release
>
>
> Enrico
>
> Il giorno mer 4 mag 2022 alle ore 20:27 Gracia, Raul
> <Ra...@dell.com> ha scritto:
> >
> > Hi all,
> >
> > -1 (not binding)
> >
> > Reason: significant performance regression found in Bookkeeper 4.15, see
> https://github.com/apache/bookkeeper/issues/3258
> > Also helping to find out where the regression could be.
> >
> > Thanks,
> > Raúl.
> >
> >
> > Internal Use - Confidential
> >
> > -----Original Message-----
> > From: Matteo Merli <ma...@gmail.com>
> > Sent: miércoles, 4 de mayo de 2022 18:58
> > To: Bookkeeper-Dev
> > Subject: Re: [VOTE] Release 4.15.0, release candidate #2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > +1
> >
> > Verified:
> >  * Checksums
> >  * Building
> >  * Starting standalone bookie
> >
> > Thanks,
> > Matteo
> >
> >
> > --
> > Matteo Merli
> > <ma...@gmail.com>
> >
> > On Wed, May 4, 2022 at 8:53 AM Andrey Yegorov <
> andrey.yegorov@datastax.com> wrote:
> > >
> > > Hi everyone,
> > >
> > > The vote has been out for 5 days - any feedback?
> > >
> > > On Fri, Apr 29, 2022 at 2:08 PM Andrey Yegorov
> > > <an...@datastax.com>
> > > wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > Please review and vote on the release candidate #1 for the version
> > > > 4.15.0, as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific
> > > > comments)
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * Release notes [1]
> > > > * The official Apache source and binary distributions to be deployed
> > > > to dist.apache.org [2]
> > > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > > * Source code tag "release-4.15.0-rc2" [4] with git sha
> > > > f771b7664f7f83ae4ae3e8eaa516c879c4bc7897
> > > >
> > > > BookKeeper's KEYS file contains PGP keys we used to sign this
> release:
> > > > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/relea
> > > > se/bookkeeper/KEYS__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3EYMaFXsAW3MjSO
> > > > HuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqIn3ZK5PmQ$
> > > > [dist[.]apache[.]org]
> > > >
> > > > Please download these packages and review this release candidate:
> > > >
> > > > - Review release notes
> > > > - Download the source package (verify shasum, and asc) and follow
> > > > the instructions to build and run the bookkeeper service.
> > > > - Download the binary package (verify shasum, and asc) and follow
> > > > the instructions to run the bookkeeper service.
> > > > - Review maven repo, release tag, licenses, and any other things you
> > > > think it is important to a release.
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> > > > majority approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Release Manager
> > > >
> > > > [1]
> > > > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/pul
> > > > l/3155/files*diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af8
> > > > 5a7964a2e57855__;Iw!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3EYMaFXsAW3MjSOHu
> > > > Em0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqImAYILkbQ$ [github[.]com]
> > > >
> > > > [2]
> > > > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/b
> > > > ookkeeper/bookkeeper-4.15.0-rc2/__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3
> > > > EYMaFXsAW3MjSOHuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqInGs8X89A$
> > > > [dist[.]apache[.]org] [3]
> > > > https://urldefense.com/v3/__https://repository.apache.org/content/re
> > > > positories/orgapachebookkeeper-1066/__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pf
> > > > pJG3EYMaFXsAW3MjSOHuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqIn4h632bQ$
> > > > [repository[.]apache[.]org] [4]
> > > > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/rel
> > > > eases/tag/v4.15.0-rc2/__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3EYMaFXsAW3
> > > > MjSOHuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqImiKfXFkA$ [github[.]com]
> > > >
> > > >
> > > > --
> > > > Andrey Yegorov
> > > >
> > >
> > >
> > > --
> > > Andrey Yegorov
> > Dell Computer SAU - C.I.F. A-80022734, Inscrita en el Registro Mercantil
> de Madrid, Tomo 1108, Folio 199, Hoja M-21115, y domicilio en Calle Ribera
> Del Loira n8, Paris Building, 28042, Madrid, España Número de inscripción
> Registro REI-RAEE: 000496.
>


-- 
Andrey Yegorov

Re: [VOTE] Release 4.15.0, release candidate #2

Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
 verified checksums, signatures, RAT
run all tests on Ubuntu JDK11

Regarding the performance issues reported by Raul while it looks scary
I don't find any performance regressions on the other projects that I
follow other than Pravega (Pulsar, HerdDB...), so I am not sure we
should hold the release.

if we find the problem I pretty sure it won't be something about a API
change or anything we can't fix in a 4.15.1 release


Enrico

Il giorno mer 4 mag 2022 alle ore 20:27 Gracia, Raul
<Ra...@dell.com> ha scritto:
>
> Hi all,
>
> -1 (not binding)
>
> Reason: significant performance regression found in Bookkeeper 4.15, see https://github.com/apache/bookkeeper/issues/3258
> Also helping to find out where the regression could be.
>
> Thanks,
> Raúl.
>
>
> Internal Use - Confidential
>
> -----Original Message-----
> From: Matteo Merli <ma...@gmail.com>
> Sent: miércoles, 4 de mayo de 2022 18:58
> To: Bookkeeper-Dev
> Subject: Re: [VOTE] Release 4.15.0, release candidate #2
>
>
> [EXTERNAL EMAIL]
>
> +1
>
> Verified:
>  * Checksums
>  * Building
>  * Starting standalone bookie
>
> Thanks,
> Matteo
>
>
> --
> Matteo Merli
> <ma...@gmail.com>
>
> On Wed, May 4, 2022 at 8:53 AM Andrey Yegorov <an...@datastax.com> wrote:
> >
> > Hi everyone,
> >
> > The vote has been out for 5 days - any feedback?
> >
> > On Fri, Apr 29, 2022 at 2:08 PM Andrey Yegorov
> > <an...@datastax.com>
> > wrote:
> >
> > > Hi everyone,
> > >
> > > Please review and vote on the release candidate #1 for the version
> > > 4.15.0, as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific
> > > comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > > * Release notes [1]
> > > * The official Apache source and binary distributions to be deployed
> > > to dist.apache.org [2]
> > > * All artifacts to be deployed to the Maven Central Repository [3]
> > > * Source code tag "release-4.15.0-rc2" [4] with git sha
> > > f771b7664f7f83ae4ae3e8eaa516c879c4bc7897
> > >
> > > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/relea
> > > se/bookkeeper/KEYS__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3EYMaFXsAW3MjSO
> > > HuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqIn3ZK5PmQ$
> > > [dist[.]apache[.]org]
> > >
> > > Please download these packages and review this release candidate:
> > >
> > > - Review release notes
> > > - Download the source package (verify shasum, and asc) and follow
> > > the instructions to build and run the bookkeeper service.
> > > - Download the binary package (verify shasum, and asc) and follow
> > > the instructions to run the bookkeeper service.
> > > - Review maven repo, release tag, licenses, and any other things you
> > > think it is important to a release.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by
> > > majority approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Release Manager
> > >
> > > [1]
> > > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/pul
> > > l/3155/files*diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af8
> > > 5a7964a2e57855__;Iw!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3EYMaFXsAW3MjSOHu
> > > Em0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqImAYILkbQ$ [github[.]com]
> > >
> > > [2]
> > > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/b
> > > ookkeeper/bookkeeper-4.15.0-rc2/__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3
> > > EYMaFXsAW3MjSOHuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqInGs8X89A$
> > > [dist[.]apache[.]org] [3]
> > > https://urldefense.com/v3/__https://repository.apache.org/content/re
> > > positories/orgapachebookkeeper-1066/__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pf
> > > pJG3EYMaFXsAW3MjSOHuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqIn4h632bQ$
> > > [repository[.]apache[.]org] [4]
> > > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/rel
> > > eases/tag/v4.15.0-rc2/__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3EYMaFXsAW3
> > > MjSOHuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqImiKfXFkA$ [github[.]com]
> > >
> > >
> > > --
> > > Andrey Yegorov
> > >
> >
> >
> > --
> > Andrey Yegorov
> Dell Computer SAU - C.I.F. A-80022734, Inscrita en el Registro Mercantil de Madrid, Tomo 1108, Folio 199, Hoja M-21115, y domicilio en Calle Ribera Del Loira n8, Paris Building, 28042, Madrid, España Número de inscripción Registro REI-RAEE: 000496.

RE: [VOTE] Release 4.15.0, release candidate #2

Posted by "Gracia, Raul" <Ra...@Dell.com>.
Hi all,

-1 (not binding)

Reason: significant performance regression found in Bookkeeper 4.15, see https://github.com/apache/bookkeeper/issues/3258
Also helping to find out where the regression could be.

Thanks,
Raúl.


Internal Use - Confidential

-----Original Message-----
From: Matteo Merli <ma...@gmail.com>
Sent: miércoles, 4 de mayo de 2022 18:58
To: Bookkeeper-Dev
Subject: Re: [VOTE] Release 4.15.0, release candidate #2


[EXTERNAL EMAIL]

+1

Verified:
 * Checksums
 * Building
 * Starting standalone bookie

Thanks,
Matteo


--
Matteo Merli
<ma...@gmail.com>

On Wed, May 4, 2022 at 8:53 AM Andrey Yegorov <an...@datastax.com> wrote:
>
> Hi everyone,
>
> The vote has been out for 5 days - any feedback?
>
> On Fri, Apr 29, 2022 at 2:08 PM Andrey Yegorov
> <an...@datastax.com>
> wrote:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #1 for the version
> > 4.15.0, as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific
> > comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed
> > to dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "release-4.15.0-rc2" [4] with git sha
> > f771b7664f7f83ae4ae3e8eaa516c879c4bc7897
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/relea
> > se/bookkeeper/KEYS__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3EYMaFXsAW3MjSO
> > HuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqIn3ZK5PmQ$
> > [dist[.]apache[.]org]
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow
> > the instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow
> > the instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> > think it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by
> > majority approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1]
> > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/pul
> > l/3155/files*diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af8
> > 5a7964a2e57855__;Iw!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3EYMaFXsAW3MjSOHu
> > Em0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqImAYILkbQ$ [github[.]com]
> >
> > [2]
> > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/b
> > ookkeeper/bookkeeper-4.15.0-rc2/__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3
> > EYMaFXsAW3MjSOHuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqInGs8X89A$
> > [dist[.]apache[.]org] [3]
> > https://urldefense.com/v3/__https://repository.apache.org/content/re
> > positories/orgapachebookkeeper-1066/__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pf
> > pJG3EYMaFXsAW3MjSOHuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqIn4h632bQ$
> > [repository[.]apache[.]org] [4]
> > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/rel
> > eases/tag/v4.15.0-rc2/__;!!LpKI!kuT1AoZ1L3lHLUu2Ui1-pfpJG3EYMaFXsAW3
> > MjSOHuEm0lPsWdzZOR9n6S1dx3z59pZOujAVMx7AqImiKfXFkA$ [github[.]com]
> >
> >
> > --
> > Andrey Yegorov
> >
>
>
> --
> Andrey Yegorov
Dell Computer SAU - C.I.F. A-80022734, Inscrita en el Registro Mercantil de Madrid, Tomo 1108, Folio 199, Hoja M-21115, y domicilio en Calle Ribera Del Loira n8, Paris Building, 28042, Madrid, España Número de inscripción Registro REI-RAEE: 000496.

Re: [VOTE] Release 4.15.0, release candidate #2

Posted by Matteo Merli <ma...@gmail.com>.
+1

Verified:
 * Checksums
 * Building
 * Starting standalone bookie

Thanks,
Matteo


--
Matteo Merli
<ma...@gmail.com>

On Wed, May 4, 2022 at 8:53 AM Andrey Yegorov
<an...@datastax.com> wrote:
>
> Hi everyone,
>
> The vote has been out for 5 days - any feedback?
>
> On Fri, Apr 29, 2022 at 2:08 PM Andrey Yegorov <an...@datastax.com>
> wrote:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #1 for the version 4.15.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "release-4.15.0-rc2" [4] with git
> > sha f771b7664f7f83ae4ae3e8eaa516c879c4bc7897
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1]
> > https://github.com/apache/bookkeeper/pull/3155/files#diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af85a7964a2e57855
> >
> > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.0-rc2/
> > [3]
> > https://repository.apache.org/content/repositories/orgapachebookkeeper-1066/
> > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.0-rc2/
> >
> >
> > --
> > Andrey Yegorov
> >
>
>
> --
> Andrey Yegorov