You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "lincoln-lil (via GitHub)" <gi...@apache.org> on 2024/01/17 15:23:06 UTC

[PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

lincoln-lil opened a new pull request, #24121:
URL: https://github.com/apache/flink/pull/24121

   ## What is the purpose of the change
   As discussed in the jira of FLINK-33182, metadata columns will not affect determinism when ChangelogNormalize is enabled, this pr aims to relax ndu-anlayze in such cases.
   
   ## Brief change log
   * add changelogNormalizeEnabled utility method to DynamicSourceUtils, so that we can have a unified logic
   * update StreamNonDeterministicUpdatePlanVisitor to treat metadata columns deterministic when ChangelogNormalize is enabled
   * add related tests
   
   ## Verifying this change
   NonDeterministicUpdateAnalyzerTest && NonDeterministicDagTest
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on PR #24121:
URL: https://github.com/apache/flink/pull/24121#issuecomment-1952690603

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr closed pull request #24121: [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize
URL: https://github.com/apache/flink/pull/24121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #24121:
URL: https://github.com/apache/flink/pull/24121#issuecomment-1897800621

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24121:
URL: https://github.com/apache/flink/pull/24121#issuecomment-1896046753

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7ac2146e6a24322d63847904e67c16d08c9c4db8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7ac2146e6a24322d63847904e67c16d08c9c4db8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7ac2146e6a24322d63847904e67c16d08c9c4db8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #24121:
URL: https://github.com/apache/flink/pull/24121#issuecomment-1953417819

   @twalthr Thank you for reviewing this!  Yes, some work was needed to make it more readable, the original scala version use the same case branch style as FlinkChangelogModeInferenceProgram, but the specific logic of Ndu was too detailed, and the if-else nesting was even deeper in the java rewritten version. Will find some time to do the refactor.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org